Skip to content

(CONT-365) Syntax update #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2023
Merged

(CONT-365) Syntax update #421

merged 3 commits into from
Mar 22, 2023

Conversation

LukasAud
Copy link
Contributor

@LukasAud LukasAud commented Mar 3, 2023

Code now compliant with rules regarding:

parameter types
empty parameter assignation
unquoted selectors

Code now compliant with rules regarding:

parameter types
empty parameter assignation
unquoted selectors
@LukasAud LukasAud requested a review from a team as a code owner March 3, 2023 15:50
@puppet-community-rangefinder
Copy link

sqlserver::config is a type

that may have no external impact to Forge modules.

sqlserver::database is a type

that may have no external impact to Forge modules.

sqlserver::login is a type

that may have no external impact to Forge modules.

sqlserver::role is a type

that may have no external impact to Forge modules.

sqlserver::user is a type

that may have no external impact to Forge modules.

This module is declared in 3 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud LukasAud changed the title (CONT-365) Syntax Syntax_update (CONT-365) Syntax update Mar 3, 2023
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 6ebbac4 into main Mar 22, 2023
@david22swan david22swan deleted the CONT-365-Syntax_update branch March 22, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants