Merge pull request #421 from puppetlabs/CONT-365-Syntax_update

(CONT-365) Syntax update

Author: david22swan

.puppet-lint.rc

@@ -1,4 +1 @@
 --relative
---no-parameter_types-check
---no-params_empty_string_assignment-check
---no-unquoted_string_in_selector-check

.sync.yml

@@ -32,8 +32,3 @@ spec/spec_helper.rb:
   unmanaged: false
 .travis.yml:
   delete: true
-Rakefile:
-  extra_disabled_lint_checks:
-    - parameter_types
-    - params_empty_string_assignment
-    - unquoted_string_in_selector

Rakefile

@@ -42,9 +42,6 @@ def changelog_future_release
 end
 
 PuppetLint.configuration.send('disable_relative')
-PuppetLint.configuration.send('disable_parameter_types')
-PuppetLint.configuration.send('disable_params_empty_string_assignment')
-PuppetLint.configuration.send('disable_unquoted_string_in_selector')
 
 
 if Bundler.rubygems.find_name('github_changelog_generator').any?

manifests/config.pp

@@ -22,22 +22,22 @@
 #   }
 #
 define sqlserver::config (
-  Variant[Sensitive[String], String] $admin_user = '',
-  Variant[Sensitive[String], String] $admin_pass = '',
-  Enum['SQL_LOGIN', 'WINDOWS_LOGIN'] $admin_login_type = 'SQL_LOGIN',
-  String[1,16] $instance_name = $title,
+  Optional[Variant[Sensitive[String], String]] $admin_user       = undef,
+  Optional[Variant[Sensitive[String], String]] $admin_pass       = undef,
+  Enum['SQL_LOGIN', 'WINDOWS_LOGIN']           $admin_login_type = 'SQL_LOGIN',
+  String[1,16]                                 $instance_name    = $title,
 ) {
   ##This config is a catalog requirement for sqlserver_tsql and is looked up to retrieve the admin_user,
   ## admin_pass and admin_login_type for a given instance_name
 
   case $admin_login_type {
     'SQL_LOGIN': {
-      if ($admin_user == '') { fail 'sqlserver::config expects admin_user to be set for a admin_login_type of SQL_LOGIN' }
-      if ($admin_pass == '') { fail 'sqlserver::config expects admin_pass to be set for a admin_login_type of SQL_LOGIN' }
+      if (!$admin_user) { fail 'sqlserver::config expects admin_user to be set for a admin_login_type of SQL_LOGIN' }
+      if (!$admin_pass) { fail 'sqlserver::config expects admin_pass to be set for a admin_login_type of SQL_LOGIN' }
     }
     'WINDOWS_LOGIN': {
-      if ($admin_user != '') { fail 'sqlserver::config expects admin_user to be empty for a admin_login_type of WINDOWS_LOGIN' }
-      if ($admin_pass != '') { fail 'sqlserver::config expects admin_pass to be empty for a admin_login_type of WINDOWS_LOGIN' }
+      if ($admin_user) { fail 'sqlserver::config expects admin_user to be empty for a admin_login_type of WINDOWS_LOGIN' }
+      if ($admin_pass) { fail 'sqlserver::config expects admin_pass to be empty for a admin_login_type of WINDOWS_LOGIN' }
     }
     default: { fail "sqlserver::config expects a admin_login_type of SQL_LOGIN or WINDOWS_LOGIN but found ${admin_login_type}" }
   }

manifests/database.pp

@@ -175,8 +175,8 @@
   sqlserver_validate_instance_name($instance)
 
   $create_delete = $ensure ? {
-    present => 'create',
-    absent  => 'delete',
+    'present' => 'create',
+    'absent'  => 'delete',
   }
 
   sqlserver_tsql { "database-${instance}-${db_name}":

manifests/login.pp

@@ -52,7 +52,7 @@
 #
 ##
 define sqlserver::login (
-  $login = $title,
+  String[1, 128] $login = $title,
   String[1,16] $instance = 'MSSQLSERVER',
   Enum['SQL_LOGIN', 'WINDOWS_LOGIN'] $login_type = 'SQL_LOGIN',
   Enum['present', 'absent'] $ensure = 'present',
@@ -72,8 +72,8 @@
   }
 
   $_create_delete = $ensure ? {
-    present => 'create',
-    absent  => 'delete',
+    'present' => 'create',
+    'absent'  => 'delete',
   }
 
   sqlserver_tsql { "login-${instance}-${login}":

manifests/role.pp

@@ -53,8 +53,8 @@
   }
 
   $_create_delete = $ensure ? {
-    present => 'create',
-    absent  => 'delete',
+    'present' => 'create',
+    'absent'  => 'delete',
   }
 
   # the title has to be unique to prevent collisions when multiple declarations

manifests/user.pp

@@ -58,8 +58,8 @@
   }
 
   $create_delete = $ensure ? {
-    present => 'create',
-    absent  => 'delete',
+    'present' => 'create',
+    'absent'  => 'delete',
   }
 
   sqlserver_tsql { "user-${instance}-${database}-${user}":

templates/instance_config.erb

@@ -1 +1,5 @@
+<%- if @admin_login_type == 'SQL_LOGIN' %>
 { "instance": "<%= @_instance %>","admin":"<%= @admin_user %>","pass":"<%= @admin_pass %>" }
+<%- else %>
+{ "instance": "<%= @_instance %>","admin":"","pass":"" }
+<%- end %>