Write facts as shared examples, move to Debian 11 and follow rspec-puppet path conventions #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
modernize-specs
branch
from
f4d1157 to
5c56fd0
Compare
bastelfreak
previously approved these changes
Nov 17, 2021
|
Hi @ekohl, can you rebase your PR please ? Thank you ! |
ekohl
force-pushed
the
modernize-specs
branch
from
5c56fd0 to
dbf628a
Compare
|
Rebased |
ekohl
force-pushed
the
modernize-specs
branch
2 times, most recently
from
9856ccf to
a893b9a
Compare
bastelfreak
previously approved these changes
Feb 3, 2022
|
Looks like lint failed, but I wonder why it didn't fail before since I'm not changing that. |
It doesn't accept nil for an optional parameter, it must be a boolean.
rspec-puppet places all classes in spec/classes and automatically applies the correct type. The same is true for defines in spec/defines.
ekohl
force-pushed
the
modernize-specs
branch
3 times, most recently
from
e3f2c51 to
f4c53d0
Compare
|
Marking it as draft since I'm abusing CI to see if my code passes because of https://tickets.puppetlabs.com/browse/MODULES-11161. If the tests are green, it should be ready. |
Previously there was a lot of duplication between facts. This now stores them as shared examples in spec_helper_local.rb and also extracts them from rspec-puppet-facts where possible. Debian 8 isn't in metadata.json anymore which meant it was testing for an unsupported OS by default. It's now changed to Debian 11.
ekohl
force-pushed
the
modernize-specs
branch
from
f4c53d0 to
f4a42a7
Compare
|
This is now failing on #1313 (comment). I'm hoping @fe80 can shed some light on this. |
bastelfreak
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rspec-puppet places all classes in spec/classes and automatically applies the correct type. The same is true for defines in spec/defines.
Previously there was a lot of duplication between facts. This now stores them as shared examples in
spec_helper_local.rband also extracts them from rspec-puppet-facts where possible.Debian 8 isn't in metadata.json anymore which meant it was testing for an unsupported OS by default. It's now changed to Debian 11.