Write facts as shared examples and move to Debian 11

Previously there was a lot of duplication between facts. This now stores
them as shared examples in spec_helper_local.rb and also extracts them
from rspec-puppet-facts where possible.

Debian 8 isn't in metadata.json anymore which meant it was testing for
an unsupported OS by default. It's now changed to Debian 11.

Author: ekohl

spec/classes/client_spec.rb

@@ -3,15 +3,7 @@
 require 'spec_helper'
 
 describe 'postgresql::client' do
-  let :facts do
-    {
-      os: {
-        family: 'Debian',
-        name: 'Debian',
-        release: { 'full' => '8.0', 'major' => '8' },
-      },
-    }
-  end
+  include_examples 'Debian 11'
 
   describe 'with parameters' do
     let :params do

spec/classes/globals_spec.rb

@@ -3,23 +3,8 @@
 require 'spec_helper'
 
 describe 'postgresql::globals' do
-  context 'on a debian 8' do
-    let(:facts) do
-      {
-        os: {
-          family: 'Debian',
-          name: 'Debian',
-          release: {
-            full: '8.0',
-            major: '8',
-          },
-          distro: { 'codename' => 'jessie' },
-        },
-        osfamily: 'Debian',
-        lsbdistid: 'Debian',
-        lsbdistcodename: 'jessie',
-      }
-    end
+  context 'on a debian 11' do
+    include_examples 'Debian 11'
 
     describe 'with no parameters' do
       it 'works' do
@@ -40,17 +25,8 @@
     end
   end
 
-  context 'on redhat family systems' do
-    let(:facts) do
-      {
-        os: {
-          family: 'RedHat',
-          name: 'RedHat',
-          release: { 'full' => '7.1', 'major' => '7' },
-        },
-        osfamily: 'RedHat',
-      }
-    end
+  context 'on redhat 7' do
+    include_examples 'RedHat 7'
 
     describe 'with no parameters' do
       it 'works' do

spec/classes/lib/devel_spec.rb

@@ -3,23 +3,15 @@
 require 'spec_helper'
 
 describe 'postgresql::lib::devel' do
-  let :facts do
-    {
-      os: {
-        family: 'Debian',
-        name: 'Debian',
-        release: { 'full' => '8.0', 'major' => '8' },
-      },
-    }
-  end
+  include_examples 'Debian 11'
 
   it { is_expected.to contain_class('postgresql::lib::devel') }
 
   describe 'link pg_config to /usr/bin' do
     it {
       is_expected.not_to contain_file('/usr/bin/pg_config') \
         .with_ensure('link') \
-        .with_target('/usr/lib/postgresql/8.4/bin/pg_config')
+        .with_target('/usr/lib/postgresql/13/bin/pg_config')
     }
   end
 
@@ -34,29 +26,13 @@
   end
 
   describe 'should not link pg_config on RedHat with default version' do
-    let(:facts) do
-      {
-        os: {
-          family: 'RedHat',
-          name: 'CentOS',
-          release: { 'full' => '6.3', 'major' => '6' },
-        },
-      }
-    end
+    include_examples 'RedHat 6'
 
     it { is_expected.not_to contain_file('/usr/bin/pg_config') }
   end
 
   describe 'link pg_config on RedHat with non-default version' do
-    let(:facts) do
-      {
-        os: {
-          family: 'RedHat',
-          name: 'RedHat',
-          release: { 'full' => '6.3', 'major' => '6' },
-        },
-      }
-    end
+    include_examples 'RedHat 6'
     let :pre_condition do
       "class { '::postgresql::globals': version => '9.3' }"
     end
@@ -69,24 +45,15 @@
   end
 
   describe 'on Gentoo' do
-    let :facts do
-      {
-        os: {
-          family: 'Gentoo',
-          name: 'Gentoo',
-        },
-      }
-    end
+    include_examples 'Gentoo'
     let :params do
       {
         link_pg_config: false,
       }
     end
 
     it 'fails to compile' do
-      expect {
-        is_expected.to compile
-      }.to raise_error(%r{is not supported})
+      is_expected.to compile.and_raise_error(%r{is not supported})
     end
   end
 end

spec/classes/lib/java_spec.rb

@@ -4,15 +4,7 @@
 
 describe 'postgresql::lib::java' do
   describe 'on a debian based os' do
-    let :facts do
-      {
-        os: {
-          family: 'Debian',
-          name: 'Debian',
-          release: { 'full' => '8.0', 'major' => '8' },
-        },
-      }
-    end
+    include_examples 'Debian 11'
 
     it {
       is_expected.to contain_package('postgresql-jdbc').with(
@@ -24,15 +16,7 @@
   end
 
   describe 'on a redhat based os' do
-    let :facts do
-      {
-        os: {
-          family: 'RedHat',
-          name: 'RedHat',
-          release: { 'full' => '6.4', 'major' => '6' },
-        },
-      }
-    end
+    include_examples 'RedHat 8'
 
     it {
       is_expected.to contain_package('postgresql-jdbc').with(

spec/classes/lib/perl_spec.rb

@@ -3,16 +3,8 @@
 require 'spec_helper'
 
 describe 'postgresql::lib::perl' do
-  describe 'on a redhat based os' do
-    let :facts do
-      {
-        os: {
-          family: 'RedHat',
-          name: 'RedHat',
-          release: { 'full' => '6.4', 'major' => '6' },
-        },
-      }
-    end
+  describe 'on redhat 8' do
+    include_examples 'RedHat 8'
 
     it {
       is_expected.to contain_package('perl-DBD-Pg').with(
@@ -22,16 +14,8 @@
     }
   end
 
-  describe 'on a debian based os' do
-    let :facts do
-      {
-        os: {
-          family: 'Debian',
-          name: 'Debian',
-          release: { 'full' => '8.0', 'major' => '8' },
-        },
-      }
-    end
+  describe 'on debian 11' do
+    include_examples 'Debian 11'
 
     it {
       is_expected.to contain_package('perl-DBD-Pg').with(

spec/classes/lib/pgdocs_spec.rb

@@ -4,15 +4,7 @@
 
 describe 'postgresql::lib::docs' do
   describe 'on a redhat based os' do
-    let :facts do
-      {
-        os: {
-          family: 'RedHat',
-          name: 'RedHat',
-          release: { 'full' => '6.4', 'major' => '6' },
-        },
-      }
-    end
+    include_examples 'RedHat 8'
 
     it {
       is_expected.to contain_package('postgresql-docs').with(

spec/classes/lib/python_spec.rb

@@ -3,16 +3,8 @@
 require 'spec_helper'
 
 describe 'postgresql::lib::python' do
-  describe 'on a redhat based os' do
-    let :facts do
-      {
-        os: {
-          family: 'RedHat',
-          name: 'RedHat',
-          release: { 'full' => '6.4', 'major' => '6' },
-        },
-      }
-    end
+  describe 'on redhat 7' do
+    include_examples 'RedHat 7'
 
     it {
       is_expected.to contain_package('python-psycopg2').with(
@@ -22,16 +14,8 @@
     }
   end
 
-  describe 'on a redhat based os with python 3' do
-    let :facts do
-      {
-        os: {
-          family: 'RedHat',
-          name: 'RedHat',
-          release: { 'full' => '8.2', 'major' => '8' },
-        },
-      }
-    end
+  describe 'on redhat 8' do
+    include_examples 'RedHat 8'
 
     it {
       is_expected.to contain_package('python-psycopg2').with(
@@ -41,16 +25,8 @@
     }
   end
 
-  describe 'on a debian based os' do
-    let :facts do
-      {
-        os: {
-          family: 'Debian',
-          name: 'Debian',
-          release: { 'full' => '8.0', 'major' => '8' },
-        },
-      }
-    end
+  describe 'on debian 11' do
+    include_examples 'Debian 11'
 
     it {
       is_expected.to contain_package('python-psycopg2').with(

spec/classes/params_spec.rb

@@ -3,15 +3,11 @@
 require 'spec_helper'
 
 describe 'postgresql::params' do
-  let :facts do
-    {
-      os: {
-        family: 'Debian',
-        name: 'Debian',
-        release: { 'full' => '8.0', 'major' => '8' },
-      },
-    }
-  end
+  on_supported_os.each do |os, os_facts|
+    context "on #{os}" do
+      let(:facts) { os_facts }
 
-  it { is_expected.to contain_class('postgresql::params') }
+      it { is_expected.to contain_class('postgresql::params') }
+    end
+  end
 end

spec/classes/repo_spec.rb

@@ -3,22 +3,7 @@
 require 'spec_helper'
 
 describe 'postgresql::repo' do
-  let :facts do
-    {
-      os: {
-        name: 'Debian',
-        family: 'Debian',
-        release: {
-          full: '8.0',
-          major: '8',
-        },
-        distro: { 'codename' => 'jessie' },
-      },
-      osfamily: 'Debian',
-      lsbdistid: 'Debian',
-      lsbdistcodename: 'jessie',
-    }
-  end
+  include_examples 'Debian 11'
 
   describe 'with no parameters' do
     it 'instantiates apt_postgresql_org class' do