Also perform systemd daemon-reload on Puppet 6.1+

[ekohl]

The way daemon-reload is implemented in Puppet 6.1 is by calling

systemctl show --property=NeedDaemonReload -- $SERVICE

If that returns yes then it performs systemctl daemon-reload. However, this
doesn't work reliable because of the particular case.

# systemctl show --property=NeedDaemonReload -- postgresql
Failed to get properties: Access denied

This is probably because the original unit file is removed.

[puppet-community-rangefinder]

postgresql::server::config is a class

that may have no external impact to Forge modules.

This module is declared in 70 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[codecov-io]

Codecov Report

Merging #1233 (18e7cf6) into main (08e3a51) will increase coverage by 0.37%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
+ Coverage   65.81%   66.18%   +0.37%     
==========================================
  Files          14       14              
  Lines         351      349       -2     
==========================================
  Hits          231      231              
+ Misses        120      118       -2     

Impacted Files	Coverage Δ
...ns/postgresql/postgresql_acls_to_resources_hash.rb	0.00% <0.00%> (ø)
...b/puppet/functions/postgresql/postgresql_escape.rb	0.00% <0.00%> (ø)
...puppet/functions/postgresql/postgresql_password.rb	0.00% <ø> (ø)
lib/puppet/functions/postgresql_escape.rb	0.00% <ø> (ø)
lib/puppet/functions/postgresql_password.rb	0.00% <ø> (ø)
lib/puppet/provider/postgresql_conf/parsed.rb	100.00% <ø> (ø)
.../puppet/provider/postgresql_conn_validator/ruby.rb	80.00% <ø> (ø)
lib/puppet/type/postgresql_conf.rb	93.33% <ø> (ø)
lib/puppet/type/postgresql_conn_validator.rb	100.00% <ø> (ø)
lib/puppet/type/postgresql_replication_slot.rb	100.00% <ø> (ø)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6e00e...18e7cf6. Read the comment docs.

[evgeni]

wording nitpick on the explanation in the comment, ACK otherwise

this is in line with what we discussed on IRC regarding how and why we've been seeing this error on Puppet6 and how to avoid it.

[sheenaajay]

Thank you @ekohl for your contribution.

[ekohl]

FYI: this is https://tickets.puppetlabs.com/browse/PUP-9473.