(IAC-1408) Release Prep v6.10.0

[sheenaajay]

No description provided.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (release@3c6e00e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             release    #1232   +/-   ##
==========================================
  Coverage           ?   66.18%           
==========================================
  Files              ?       14           
  Lines              ?      349           
  Branches           ?        0           
==========================================
  Hits               ?      231           
  Misses             ?      118           
  Partials           ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6e00e...83e09d0. Read the comment docs.

[ekohl]

FYI: we did see a pipeline fail on a PostgreSQL service restart which was running Puppet 6. I'm debugging that now, but if that's the same bug as #1230 then perhaps it needs additional work.

[ekohl]

In the review of #1230 I was very much under the impression that it only affected Puppet 5. However, in our system upgrades we also see a problem with Puppet 6 which doesn't perform the daemon-reload. It is my theory that /bin/systemctl show --property=NeedDaemonReload -- postgresql returns something other than yes so that https://github.com/puppetlabs/puppet/blob/97ca00bcb935a2efe7a6cac1b8e071418b9a3dc4/lib/puppet/provider/service/systemd.rb#L150-L153 is never triggered. I think that's probably because the unit file is missing entirely according to systemd.

I'll try to write up a PR and I'd appreciate it if that could make it into the release.

[sheenaajay]

In the review of #1230 I was very much under the impression that it only affected Puppet 5. However, in our system upgrades we also see a problem with Puppet 6 which doesn't perform the daemon-reload. It is my theory that /bin/systemctl show --property=NeedDaemonReload -- postgresql returns something other than yes so that https://github.com/puppetlabs/puppet/blob/97ca00bcb935a2efe7a6cac1b8e071418b9a3dc4/lib/puppet/provider/service/systemd.rb#L150-L153 is never triggered. I think that's probably because the unit file is missing entirely according to systemd.

I'll try to write up a PR and I'd appreciate it if that could make it into the release.

Thanks alot @ekohl will hold on the release .

[ekohl]

I submitted #1233 and would like to see it included.

[sheenaajay]

I submitted #1233 and would like to see it included.

Yeah sure. Thank you