Update to enable Rubocop and contains Rubocop fixes in lib/ #974
Conversation
HelenCampbell
changed the title
| end | ||
|
|
||
| def destroy | ||
| # rubocop:disable Lint/UselessAssignment |
There was a problem hiding this comment.
this can just go on the offending line
| end | ||
|
|
||
| def self.prefetch(resources) | ||
| users = instances | ||
| resources.keys.each do |name| | ||
| # rubocop:disable Lint/AssignmentInCondition |
| @@ -19,19 +18,21 @@ def self.instances | |||
| def self.prefetch(resources) | |||
| plugins = instances | |||
| resources.keys.each do |plugin| | |||
| # rubocop:disable Lint/AssignmentInCondition | |||
| let(:facts) do | ||
| { | ||
| :osfamily => 'UNSUPPORTED', | ||
|
|
There was a problem hiding this comment.
this looks weird, a misedit ?
HelenCampbell
force-pushed
the
i18nTesting
branch
2 times, most recently
from
cba18fe to
e03d382
Compare
| return false unless hash.has_key?( other_key ) | ||
| hash[key] = hash.delete( other_key ) | ||
| return true; | ||
| def normalized!(hash, key) |
There was a problem hiding this comment.
normalized?(hash,key)? as long as we're changing it. i guess that doesn't have much to do with rubocop specifically...
lib/puppet/provider/mysql.rb
Outdated
| commands :mysqladmin => 'mysqladmin' | ||
| commands mysql: 'mysql' | ||
| commands mysqld: 'mysqld' | ||
| commands mysqladmin: 'mysqladmin' |
There was a problem hiding this comment.
was rocket alignment important here? this isn't the only module it's present in and it does have a certain allure.
| table.sub(%r{^PROCEDURE (.*)(\..*)}, 'PROCEDURE `\1`\2') | ||
| else | ||
| table.sub(%r{^(.*)(\..*)}, '`\1`\2') | ||
| end | ||
| table_string |
There was a problem hiding this comment.
do we need this if we're changing to the rubocop'd syntax?
There was a problem hiding this comment.
Not sure what you mean here?
Updated with all your other comments 👍
There was a problem hiding this comment.
we can fix this later if needs be
| def create | ||
| name = @resource[:name] | ||
| name = @resource[:name] |
There was a problem hiding this comment.
this looks kinda goofy, i wonder why it only de-aligned name
| let(:facts) do | ||
| { | ||
| { |
HelenCampbell
force-pushed
the
i18nTesting
branch
from
e03d382 to
c559036
Compare
HelenCampbell
changed the title
No description provided.