Skip to content

Commit cba18fe

Browse files
Helen CampbellHelen Campbell
Helen Campbell
authored and
Helen Campbell
committed
Merge branch 'i18nTesting' of github.com:puppetlabs/puppetlabs-mysql into i18nTesting
2 parents e236b38 + 44a955e commit cba18fe

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

lib/puppet/provider/mysql_datadir/mysql.rb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ def create
3434

3535
opts = [defaults_extra_file]
3636
%w[basedir datadir user].each do |opt|
37-
# rubocop:disable Security/Eval
38-
val = eval(opt)
39-
# rubocop:enable Security/Eval
37+
val = eval(opt) # rubocop:disable Security/Eval
4038
opts << "--#{opt}=#{val}" unless val.nil?
4139
end
4240

@@ -57,9 +55,7 @@ def create
5755
end
5856

5957
def destroy
60-
# rubocop:disable Lint/UselessAssignment
61-
name = @resource[:name]
62-
# rubocop:enable Lint/UselessAssignment
58+
name = @resource[:name] # rubocop:disable Lint/UselessAssignment
6359
raise ArgumentError, 'ERROR: Resource can not be removed'
6460
end
6561

lib/puppet/provider/mysql_plugin/mysql.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@ def self.instances
1818
def self.prefetch(resources)
1919
plugins = instances
2020
resources.keys.each do |plugin|
21-
# rubocop:disable Lint/AssignmentInCondition
22-
if provider = plugins.find { |pl| pl.name == plugin }
21+
if provider = plugins.find { |pl| pl.name == plugin } # rubocop:disable Lint/AssignmentInCondition
2322
resources[plugin].provider = provider
2423
end
25-
# rubocop:enable Lint/AssignmentInCondition
2624
end
2725
end
2826

spec/classes/graceful_failures_spec.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@
44
context "on an unsupported OS" do
55
let(:facts) do
66
{
7-
:osfamily => 'UNSUPPORTED',
7+
:osfamily => 'UNSUPPORTED',
88
:operatingsystem => 'UNSUPPORTED'
99
}
10-
end
11-
10+
end
1211
it 'should gracefully fail' do
1312
is_expected.to compile.and_raise_error(/Unsupported platform:/)
1413
end

0 commit comments

Comments
 (0)