-
Notifications
You must be signed in to change notification settings - Fork 795
Change also service_name for Fedora #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this the same as #420 only with a sensible commit message? |
It appears one way or another you'll have to rebase this. |
Is this also true for RHEL 7? |
I don't have RHEL 7 |
The answer is: Yes. https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/7-Beta/html/7.0_Release_Notes/chap-web-servers-and-servces.html - MariaDB is the default MySQL on RHEL7. |
@igalic, basicaly you are right, but note that #420 does not fix the service_name issue at all (without the fix this module is useless on Fedora-20+). It only changes log file accordingly. I did not have problems with running mariadb with /var/log/mysqld.log, but I can add this to my patch, if you want me to do it. Do you want me to implement fix for RHEL-7 too in this patch? |
That's exactly what I meant with my previous comment, "both are incomplete" |
I just got a RHEL-7 ISO, and I will try my fix on RHEL-7 then. |
@igalic, so I rebased and implemented also RHEL-7+ changes. I don't think that changing a log file path is necessary. Using the log file works and don't need any additional changes. |
I have no opinion on that, because I don't use Fedora/RHEL/CentOS. That's why I asked you / @kingheaven - and you two can't agree. I may have to ask higher powers for their opinion: pinging @apenney. @apenney to the MySQL room please! |
@igalic: So after playing a bit more with mariadb on F20 I realized that log file is issue after all, so I added @kingheaven's patch to my patch. |
On Fedora-20+ and RHEL-7+ mysqld service does not work any more and has been replaced by mariadb service. This patch changes all parameters accordingly.
Tested on Fedora-20, RHEL-6.5, RHEL-7 |
Not sure why Travis CI is failing on rake installation :/. |
it's failing due to an issue I already fixed in #493 |
Change also service_name for Fedora
VERY WELL THEN! Merged,. |
Thanks a lot :). |
On Fedora-20+ mysqld service does not work any more and has been
replaced by mariadb service.
This patch has been tested both on Fedora 19 and Fedora 20.