Skip to content

Change also service_name for Fedora #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2014
Merged

Change also service_name for Fedora #429

merged 1 commit into from
Apr 2, 2014

Conversation

paramite
Copy link
Contributor

On Fedora-20+ mysqld service does not work any more and has been
replaced by mariadb service.

This patch has been tested both on Fedora 19 and Fedora 20.

@igalic
Copy link
Contributor

igalic commented Jan 24, 2014

Is this the same as #420 only with a sensible commit message?

@igalic
Copy link
Contributor

igalic commented Jan 24, 2014

It appears one way or another you'll have to rebase this.

@igalic
Copy link
Contributor

igalic commented Jan 25, 2014

Is this also true for RHEL 7?

@darth30joker
Copy link

I don't have RHEL 7

@igalic
Copy link
Contributor

igalic commented Jan 26, 2014

@paramite
Copy link
Contributor Author

@igalic, basicaly you are right, but note that #420 does not fix the service_name issue at all (without the fix this module is useless on Fedora-20+). It only changes log file accordingly. I did not have problems with running mariadb with /var/log/mysqld.log, but I can add this to my patch, if you want me to do it.

Do you want me to implement fix for RHEL-7 too in this patch?

@igalic
Copy link
Contributor

igalic commented Jan 27, 2014

So, neither this, nor #420 are complete then, or compatible between each other?

@paramite yes, please. And also, rebase, please.

@darth30joker
Copy link

@paramite @igalic As I can see, default log file is located in /var/log/mariadb/mariadb.log. We'd better keep it there.
What about it?

@igalic
Copy link
Contributor

igalic commented Jan 27, 2014

That's exactly what I meant with my previous comment, "both are incomplete"

@darth30joker
Copy link

I just got a RHEL-7 ISO, and I will try my fix on RHEL-7 then.

@paramite
Copy link
Contributor Author

@igalic, so I rebased and implemented also RHEL-7+ changes. I don't think that changing a log file path is necessary. Using the log file works and don't need any additional changes.

@igalic
Copy link
Contributor

igalic commented Jan 27, 2014

I have no opinion on that, because I don't use Fedora/RHEL/CentOS. That's why I asked you / @kingheaven - and you two can't agree.

I may have to ask higher powers for their opinion: pinging @apenney. @apenney to the MySQL room please!

@paramite
Copy link
Contributor Author

paramite commented Feb 5, 2014

@igalic: So after playing a bit more with mariadb on F20 I realized that log file is issue after all, so I added @kingheaven's patch to my patch.

On Fedora-20+ and RHEL-7+ mysqld service does not work any more
and has been replaced by mariadb service. This patch changes all
parameters accordingly.
@paramite
Copy link
Contributor Author

Tested on Fedora-20, RHEL-6.5, RHEL-7

@paramite
Copy link
Contributor Author

Not sure why Travis CI is failing on rake installation :/.

@igalic
Copy link
Contributor

igalic commented Apr 2, 2014

it's failing due to an issue I already fixed in #493
Unfortunately, I have no permissions to kick the build off again, but we can be pretty sure it'll work on the other platforms just as well as it does on ruby 1.9

@paramite
Copy link
Contributor Author

paramite commented Apr 2, 2014

Ok great, so can we move forward with this before yet another RHEL-7/Fedora-20 pull request will be created by another developer? This pull request contains code which is contained in both #494 and #420.

igalic added a commit that referenced this pull request Apr 2, 2014
Change also service_name for Fedora
@igalic igalic merged commit b3dc36a into puppetlabs:master Apr 2, 2014
@igalic
Copy link
Contributor

igalic commented Apr 2, 2014

VERY WELL THEN! Merged,.

@paramite
Copy link
Contributor Author

paramite commented Apr 2, 2014

Thanks a lot :).

@igalic igalic mentioned this pull request Apr 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants