Skip to content

Fix issue: #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix issue: #420

wants to merge 1 commit into from

Conversation

darth30joker
Copy link

Fedora, starting from 19 ships with MariaDB as its default MySQL.
In order to keep supporting this distro we need to make a number of
changes:

  1. Change service name to mariadb
  2. Change log file to /var/log/mariadb/mariadb.log
  3. Change ownership of log file to mysql

@igalic
Copy link
Contributor

igalic commented Jan 22, 2014

Do I understand this correctly, is F19/F20 shipping MariaDB by default?

One way or another, please fix the the commit message.

@darth30joker
Copy link
Author

@igalic Yes, MariaDB is shipped on F19/F20 by default.

There are 3 things need be done there:

  1. Change service name to mariadb
  2. Change log file to /var/log/mariadb/mariadb.log
  3. Change ownership of log file to mysql

@igalic
Copy link
Contributor

igalic commented Jan 24, 2014

I'm perfectly aware of that from looking at the code you want to merge, but it's not obvious from your commit message.
it should read something like this:

MySQL (mariadb) support on Fedora 19+ is broken

Fedora, starting 19 ships with MariaDB as its default MySQL.
In order to keep supporting this distro we need to make a number of changes:
<stuff you wrote>

Fedora, starting from 19 ships with MariaDB as its default MySQL.
In order to keep supporting this distro we need to make a number of
changes:

1. Change service name to mariadb
2. Change log file to /var/log/mariadb/mariadb.log
3. Change ownership of log file to mysql
@igalic
Copy link
Contributor

igalic commented Jan 25, 2014

Is this also true for RHEL 7?

@igalic
Copy link
Contributor

igalic commented Jan 26, 2014

@darth30joker
Copy link
Author

Thank you, @igalic

@igalic
Copy link
Contributor

igalic commented Apr 4, 2014

@kingheaven could you please rebase this, after #429?

@darth30joker
Copy link
Author

OK, I will.

David Xie
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Friday, 4 April, 2014 at 18:15, Igor Galić wrote:

@kingheaven (https://github.com/kingheaven) could you please rebase this, after #429 (#429)?


Reply to this email directly or view it on GitHub (#420 (comment)).

@darth30joker
Copy link
Author

@igalic Since #429 already contains everything I updated, so I suggest close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants