Upgrade the golang version for the quota-management branch. #313

z103cb · 2023-04-04T14:16:20Z

Updated travis config for the new version
Updated build.sh scripts for the new version

Updated travis config for the new version Updated build.sh scripts for the new version

Updates to travis.yml, to set dist Added the generated.deepcopy files

Other fixes to the makefile and e2e test

Updates to util.go to allow for different images to be used.

* Changes to the run-e2e-kind.sh to * Changed out echo server image, small edits * Backed out change in the clean up code. * Updated the makefile to build the executable * Address code review comments. * * Small changes to the e2e script * Build documentation updates. * Documentation updates per code review Fixed errors in the e2e script to load ubuntu:latest image correctly. * Cleaned up false errors Rectified use of undefined variable.

jbusche · 2023-04-06T02:13:59Z

I checked out the vulnerabilities. The original mcad-controller:main-v1.29.55 has 59 vulnerabilities:

vulnerabilityFailureSummary | C:3/H:41/M:14/L:1/T:59

Your newer image is much improved, only 21:

vulnerabilityFailureSummary | C:1/H:14/M:6/L:0/T:21

jbusche · 2023-04-06T02:29:11Z

I tried changing my deployment to utilize the image I built off your branch, and was able to train the batch_mnist.ipynb

AppStatus:
  msg: !!python/object/apply:ray.dashboard.modules.job.common.JobStatus
  - SUCCEEDED
  num_restarts: -1
  roles:
  - replicas:
    - hostname: <NONE>
      id: 0
      role: ray
      state: !!python/object/apply:torchx.specs.api.AppState
      - 4
      structured_error_msg: <NONE>
    role: ray
  state: SUCCEEDED (4)
  structured_error_msg: <NONE>
  ui_url: null

oc describe pod mcad-controller-mcad-566d8bbb9f-nkfvf |grep Image

    Image:         quay.io/project-codeflare/mcad-controller:quota-management-go-update-v1.29.55-rc1

z103cb · 2023-04-07T09:44:02Z

I checked out the vulnerabilities. The original mcad-controller:main-v1.29.55 has 59 vulnerabilities:
vulnerabilityFailureSummary | C:3/H:41/M:14/L:1/T:59
Your newer image is much improved, only 21:
vulnerabilityFailureSummary | C:1/H:14/M:6/L:0/T:21

Would it be possible to see the list of vulnerabilities ? Can you PM those ?

z103cb · 2023-04-07T09:44:31Z

I tried changing my deployment to utilize the image I built off your branch, and was able to train the batch_mnist.ipynb

AppStatus:
  msg: !!python/object/apply:ray.dashboard.modules.job.common.JobStatus
  - SUCCEEDED
  num_restarts: -1
  roles:
  - replicas:
    - hostname: <NONE>
      id: 0
      role: ray
      state: !!python/object/apply:torchx.specs.api.AppState
      - 4
      structured_error_msg: <NONE>
    role: ray
  state: SUCCEEDED (4)
  structured_error_msg: <NONE>
  ui_url: null

oc describe pod mcad-controller-mcad-566d8bbb9f-nkfvf |grep Image

    Image:         quay.io/project-codeflare/mcad-controller:quota-management-go-update-v1.29.55-rc1

@jbusche thank you very much for the feedback.

Makefile updates

Updated documentation Minor changes to makefile

debug messages for the e2e script.

Cleanup of junk files.

z103cb · 2023-04-11T07:44:00Z

@dmatch01 I would appreciate your feedback on this PR.

* Updated the go version in go.mod Ran `go mod tidy` Updated travis.yml Deleted staled code, disabled the quota manager in the controller. * Added travis changes. * Removed linter install Ported changes to .travis.yml from quota-management-branch * Removed linter install Ported changes to .travis.yml from quota-management-branch * Downgraded go to version 1.18 to allow for use of ubi images. * Added use of docker builder using ubi8 images Makefile updates * Cleaned up the obsolete build scripts Updated documentation Minor changes to makefile * Small fix to the docker file. * More updates to go.mod to fix vulnerabilities * Removed text files. * Yet another text file removal * Small fix to address PR review comments.

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>

* Adding Performance test script Signed-off-by: James Busche <jbusche@us.ibm.com> * red hat image and more checking Signed-off-by: James Busche <jbusche@us.ibm.com> * Check for mcad install Signed-off-by: James Busche <jbusche@us.ibm.com> * remove oc and formatting Signed-off-by: James Busche <jbusche@us.ibm.com> * fix to run from any namespace Signed-off-by: James Busche <jbusche@us.ibm.com> --------- Signed-off-by: James Busche <jbusche@us.ibm.com>

dmatch01

Many "thanks" comments, a few Qs.

Makefile

deployment/build-inside-container-private.sh

doc/build/build.md

private.mod

.devcontainer/devcontainer.json

dmatch01 · 2023-04-19T05:02:59Z

hack/run-e2e-kind.sh

Quite a bit of changes to the file, thus a bit difficult to verify/validate. But I will run locally to test and check Travis. Thanks for the clean up!

@dmatch01 you are welcome.

I might have went a little overboard with the refactoring :)

No worries at all. This is really great! Did the make run-e2e and ran into a few things starting here:

$ make run-e2e "---" "MAKE GLOBAL VARIABLES:" " "BIN_DIR="_output/bin" " "GIT_BRANCH="quota-management-go-update" " "RELEASE_VER="v1.29.55" " "TAG="quota-management-go-update-v1.29.55" "---" # Check for invalid tag name t=quota-management-go-update-v1.29.55 && [ ${#t} -le 128 ] || { echo "Target name $t has 128 or more chars"; false; } echo "Running e2e with MCAD local image: mcad-controller quota-management-go-update-v1.29.55 IfNotPresent." Running e2e with MCAD local image: mcad-controller quota-management-go-update-v1.29.55 IfNotPresent. hack/run-e2e-kind.sh mcad-controller quota-management-go-update-v1.29.55 IfNotPresent CPU architecture for downloads is: amd64 Password:

Will capture the items in separate comments.

…-codeflare#328) Signed-off-by: Kevin <kpostlet@redhat.com>

Makefile

Dockerfile

doc/build/build.md

Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.4 to 0.3.8. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.4...v0.3.8) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…project-codeflare#324) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20210405180319-a5a99cb37ef4 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](https://github.com/golang/net/commits/v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/gogo/protobuf/releases) - [Commits](gogo/protobuf@v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: github.com/gogo/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Removed directory from commit.

…1.0 (project-codeflare#322) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20201002170205-7f63de1d35b0 to 0.1.0. - [Release notes](https://github.com/golang/crypto/releases) - [Commits](https://github.com/golang/crypto/commits/v0.1.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

dmatch01

Still working through the local e2e but wanted to share these details while traveling.

dmatch01 · 2023-04-20T14:50:39Z

hack/run-e2e-kind.sh

No worries at all. This is really great! Did the make run-e2e and ran into a few things starting here:

$ make run-e2e "---" "MAKE GLOBAL VARIABLES:" " "BIN_DIR="_output/bin" " "GIT_BRANCH="quota-management-go-update" " "RELEASE_VER="v1.29.55" " "TAG="quota-management-go-update-v1.29.55" "---" # Check for invalid tag name t=quota-management-go-update-v1.29.55 && [ ${#t} -le 128 ] || { echo "Target name $t has 128 or more chars"; false; } echo "Running e2e with MCAD local image: mcad-controller quota-management-go-update-v1.29.55 IfNotPresent." Running e2e with MCAD local image: mcad-controller quota-management-go-update-v1.29.55 IfNotPresent. hack/run-e2e-kind.sh mcad-controller quota-management-go-update-v1.29.55 IfNotPresent CPU architecture for downloads is: amd64 Password:

Will capture the items in separate comments.

hack/run-e2e-kind.sh

…in tutorial (project-codeflare#333) Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

* non-root 1000 user Signed-off-by: James Busche <jbusche@us.ibm.com> * cleanup dockerfile Signed-off-by: James Busche <jbusche@us.ibm.com> * moving curl into builder Signed-off-by: James Busche <jbusche@us.ibm.com> --------- Signed-off-by: James Busche <jbusche@us.ibm.com>

* Update Dockerfile: * To not to use root user to build * To allow for passing of golang build args Updated Makefile: * To selectively run the generate code * To allow for passing of golang build args * Updates to ensure that docker builds flags are used Update to the e2e script to allow for not caching test runs and cluster setup * Updates to e2e script and travis for log level Fixed 1 race condition issue. * Reverted needless changes. * Documentation updates. Minor fixes to make file. * Fixed bug in docker file Reduced noise in e2e test. * Fixed potential regression. * Added back Dockerfile

asm582 · 2023-04-30T14:47:56Z

This PR looks good to me, @jbusche @KPostOffice can you please share what is pending?

asm582 · 2023-05-02T22:44:33Z

LGTM

jbusche · 2023-05-03T00:15:19Z

I'm sorry @asm582, I got behind looking at it - I built the latest image off this branch and it looks good to me, memory is looking good and performance looks as expected. Thanks for merging!

* Move POC rest impl. to quota plubins. * Initial checkin of new quota management. * Partial update to e2e script to enable instatiate 2 differently configured mcad controllers. * Added kuttl installation to e2e test. * Synced version file. * Modified kuttl installation to include sudo for commands. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added startup of MCAD with Quota Management enabled Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added kuttl test command to e2e testing. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Provided an alternative to the travis_wait command. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added full e2e testing back. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added explicit kuttl config file. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Set e2e test to above if kuttl test fails. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Uptick of release number. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Fix syntax error. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added creation of test namespace to kuttl testing steps. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test kuttl failure in Travis run. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test kuttle success run in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Fix job names to match file names and increased timeout for preemption to happen. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Increase kuttle timeout. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test kuttle success run in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Use different color code for e2e PID message. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Debugging kuttl failure. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Rearrange setup of kuttl test for more stability of test. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Introduced forced error test to validate new Travis workaround for long running Travis job. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Force final failure test for e2e kuttl test. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Removed forced failure for Travis testing. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added delay step 3 to give time for MCAD to process subtrees. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Updated QM test to use Helm3 Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Quota management porting of initial codebase (#269) * Move POC rest impl. to quota plubins. * Initial checkin of new quota management. * Partial update to e2e script to enable instatiate 2 differently configured mcad controllers. * Added kuttl installation to e2e test. * Synced version file. * Modified kuttl installation to include sudo for commands. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added startup of MCAD with Quota Management enabled Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added kuttl test command to e2e testing. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Provided an alternative to the travis_wait command. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added full e2e testing back. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added explicit kuttl config file. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Set e2e test to above if kuttl test fails. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Uptick of release number. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Fix syntax error. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added creation of test namespace to kuttl testing steps. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test kuttl failure in Travis run. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test kuttle success run in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Fix job names to match file names and increased timeout for preemption to happen. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Increase kuttle timeout. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test kuttle success run in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Use different color code for e2e PID message. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Debugging kuttl failure. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Rearrange setup of kuttl test for more stability of test. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Introduced forced error test to validate new Travis workaround for long running Travis job. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Force final failure test for e2e kuttl test. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Removed forced failure for Travis testing. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added delay step 3 to give time for MCAD to process subtrees. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Updated QM test to use Helm3 Signed-off-by: dmatch01 <darroyo@us.ibm.com> --------- Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added the new path QM test using new Helm3 setup. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Upgrade the golang version for the quota-management branch. (#313) * update (#298) * Upgraded the golang version Updated travis config for the new version Updated build.sh scripts for the new version * Updates to go.mod Updates to travis.yml, to set dist Added the generated.deepcopy files * Removed unused package. * e2e test script updates * Queue.go updates Other fixes to the makefile and e2e test * Updates to the e2e script Updates to util.go to allow for different images to be used. * Updates to to local host setup * Changes to the run-e2e-kind.sh locally (#290) * Changes to the run-e2e-kind.sh to * Changed out echo server image, small edits * Backed out change in the clean up code. * Updated the makefile to build the executable * Address code review comments. * * Small changes to the e2e script * Build documentation updates. * Documentation updates per code review Fixed errors in the e2e script to load ubuntu:latest image correctly. * Cleaned up false errors Rectified use of undefined variable. * Downgraded go to version 1.18 to allow for use of ubi images. * Downgraded travis ubuntu distro * Added use of docker builder using ubi8 images Makefile updates * Cleaned up the obsolete build scripts Updated documentation Minor changes to makefile * avoid preempt of failed co-schd pods (#317) * Update CONTROLLER_VERSION * Updates to travis and devcontainer * Small updates to the run-e2e test * Updated go-restful dependency * More go.mod updates debug messages for the e2e script. * Added back in the removal of taints from head node Cleanup of junk files. * Remove whitesapce * Small corrections. * Refactoring of env-setup * moe arch issues with the kuttl binnary * Updated the go version in go.mod (#316) * Updated the go version in go.mod Ran `go mod tidy` Updated travis.yml Deleted staled code, disabled the quota manager in the controller. * Added travis changes. * Removed linter install Ported changes to .travis.yml from quota-management-branch * Removed linter install Ported changes to .travis.yml from quota-management-branch * Downgraded go to version 1.18 to allow for use of ubi images. * Added use of docker builder using ubi8 images Makefile updates * Cleaned up the obsolete build scripts Updated documentation Minor changes to makefile * Small fix to the docker file. * More updates to go.mod to fix vulnerabilities * Removed text files. * Yet another text file removal * Small fix to address PR review comments. * Create 1.29.57 release Signed-off-by: Anish Asthana <anishasthana1@gmail.com> * Adding Performance test script (#289) * Adding Performance test script Signed-off-by: James Busche <jbusche@us.ibm.com> * red hat image and more checking Signed-off-by: James Busche <jbusche@us.ibm.com> * Check for mcad install Signed-off-by: James Busche <jbusche@us.ibm.com> * remove oc and formatting Signed-off-by: James Busche <jbusche@us.ibm.com> * fix to run from any namespace Signed-off-by: James Busche <jbusche@us.ibm.com> --------- Signed-off-by: James Busche <jbusche@us.ibm.com> * fix typo (#326) * Document updates. * remove invalid characters from branch name an replace with - (#328) Signed-off-by: Kevin <kpostlet@redhat.com> * Bump golang.org/x/text from 0.3.4 to 0.3.8 (#321) Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.4 to 0.3.8. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.4...v0.3.8) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.0.0-20210405180319-a5a99cb37ef4 to 0.7.0 (#324) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20210405180319-a5a99cb37ef4 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](https://github.com/golang/net/commits/v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/gogo/protobuf from 1.3.1 to 1.3.2 (#323) Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/gogo/protobuf/releases) - [Commits](gogo/protobuf@v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: github.com/gogo/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added .devcontainer to gitignore Removed directory from commit. * Codereview comments. * Bump golang.org/x/crypto from 0.0.0-20201002170205-7f63de1d35b0 to 0.1.0 (#322) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20201002170205-7f63de1d35b0 to 0.1.0. - [Release notes](https://github.com/golang/crypto/releases) - [Commits](https://github.com/golang/crypto/commits/v0.1.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixes to the setup part of the script. * change schedSpec to schedulingSpec and note M1 image for echo server in tutorial (#333) Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> * Changes user to 1000 (#329) * non-root 1000 user Signed-off-by: James Busche <jbusche@us.ibm.com> * cleanup dockerfile Signed-off-by: James Busche <jbusche@us.ibm.com> * moving curl into builder Signed-off-by: James Busche <jbusche@us.ibm.com> --------- Signed-off-by: James Busche <jbusche@us.ibm.com> * Address race condition in XController variable (#330) * Update Dockerfile: * To not to use root user to build * To allow for passing of golang build args Updated Makefile: * To selectively run the generate code * To allow for passing of golang build args * Updates to ensure that docker builds flags are used Update to the e2e script to allow for not caching test runs and cluster setup * Updates to e2e script and travis for log level Fixed 1 race condition issue. * Reverted needless changes. * Documentation updates. Minor fixes to make file. * Fixed bug in docker file Reduced noise in e2e test. * Fixed potential regression. * Added back Dockerfile * Fix bad merge. --------- Signed-off-by: Anish Asthana <anishasthana1@gmail.com> Signed-off-by: James Busche <jbusche@us.ibm.com> Signed-off-by: Kevin <kpostlet@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Abhishek Malvankar <asm582@users.noreply.github.com> Co-authored-by: Mustafa Eyceoz <maxusmusti@gmail.com> Co-authored-by: Anish Asthana <anishasthana1@gmail.com> Co-authored-by: James Busche <101845348+jbusche@users.noreply.github.com> Co-authored-by: Lionel Villard <villard@us.ibm.com> Co-authored-by: Kevin Postlethwait <k.postlethwait24@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sunyanan Choochotkaew <sunya-ch@ist.osaka-u.ac.jp> --------- Signed-off-by: dmatch01 <darroyo@us.ibm.com> Signed-off-by: Anish Asthana <anishasthana1@gmail.com> Signed-off-by: James Busche <jbusche@us.ibm.com> Signed-off-by: Kevin <kpostlet@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> Co-authored-by: dmatch01 <darroyo@us.ibm.com> Co-authored-by: dmatch01 <dmatch01@users.noreply.github.com> Co-authored-by: Laurentiu Bradin <109964136+z103cb@users.noreply.github.com> Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Mustafa Eyceoz <maxusmusti@gmail.com> Co-authored-by: Anish Asthana <anishasthana1@gmail.com> Co-authored-by: James Busche <101845348+jbusche@users.noreply.github.com> Co-authored-by: Lionel Villard <villard@us.ibm.com> Co-authored-by: Kevin Postlethwait <k.postlethwait24@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sunyanan Choochotkaew <sunya-ch@ist.osaka-u.ac.jp>

kevin85421 and others added 9 commits March 30, 2023 15:07

update (project-codeflare#298)

c03d7c6

Upgraded the golang version

4e8c15a

Updated travis config for the new version Updated build.sh scripts for the new version

Updates to go.mod

2413b9c

Updates to travis.yml, to set dist Added the generated.deepcopy files

Removed unused package.

92080d4

e2e test script updates

b8bf641

Queue.go updates

8f6d3a0

Other fixes to the makefile and e2e test

Updates to the e2e script

a491587

Updates to util.go to allow for different images to be used.

Updates to to local host setup

0fb9e05

z103cb added 4 commits April 7, 2023 12:47

Downgraded go to version 1.18 to allow for use of ubi images.

cc204e3

Downgraded travis ubuntu distro

0b8d563

Added use of docker builder using ubi8 images

70cfc8b

Makefile updates

Cleaned up the obsolete build scripts

394534f

Updated documentation Minor changes to makefile

z103cb changed the title ~~Upgraded the golang version~~ Upgrade the golang version for the quota-management branch. Apr 7, 2023

asm582 and others added 11 commits April 7, 2023 11:55

avoid preempt of failed co-schd pods (project-codeflare#317)

d587352

Update CONTROLLER_VERSION

bc8fca0

Updates to travis and devcontainer

50e07ec

Small updates to the run-e2e test

eec1ca3

Updated go-restful dependency

b4033c7

More go.mod updates

8086c98

debug messages for the e2e script.

Added back in the removal of taints from head node

d5e9b09

Cleanup of junk files.

Remove whitesapce

36215a7

Small corrections.

3c2d181

Refactoring of env-setup

0499084

moe arch issues with the kuttl binnary

40df1d9

z103cb marked this pull request as ready for review April 11, 2023 07:43

z103cb and others added 4 commits April 13, 2023 09:43

Create 1.29.57 release

301e8f8

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>

fix typo (project-codeflare#326)

38b4d07

dmatch01 reviewed Apr 19, 2023

View reviewed changes

z103cb and others added 2 commits April 19, 2023 12:46

Document updates.

2bde9da

remove invalid characters from branch name an replace with - (project…

e738a4c

…-codeflare#328) Signed-off-by: Kevin <kpostlet@redhat.com>

KPostOffice reviewed Apr 19, 2023

View reviewed changes

Makefile Outdated Show resolved Hide resolved

Makefile Show resolved Hide resolved

Dockerfile Show resolved Hide resolved

doc/build/build.md Outdated Show resolved Hide resolved

dependabot bot and others added 6 commits April 19, 2023 15:32

Added .devcontainer to gitignore

53ede34

Removed directory from commit.

Codereview comments.

4feef77

dmatch01 reviewed Apr 20, 2023

View reviewed changes

z103cb and others added 4 commits April 21, 2023 07:26

Fixes to the setup part of the script.

ee4acd9

change schedSpec to schedulingSpec and note M1 image for echo server …

970dd12

…in tutorial (project-codeflare#333) Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>

z103cb added 2 commits May 2, 2023 17:46

Merge branch 'main' into quota-management-go-update

528417a

Fix bad merge.

39bd977

asm582 merged commit 61d65a9 into project-codeflare:quota-management May 2, 2023

z103cb deleted the quota-management-go-update branch July 17, 2023 14:02

Upgrade the golang version for the quota-management branch. #313

Upgrade the golang version for the quota-management branch. #313

Uh oh!

Conversation

z103cb commented Apr 4, 2023

Uh oh!

jbusche commented Apr 6, 2023

Uh oh!

jbusche commented Apr 6, 2023

Uh oh!

z103cb commented Apr 7, 2023

Uh oh!

z103cb commented Apr 7, 2023

Uh oh!

z103cb commented Apr 11, 2023

Uh oh!

dmatch01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmatch01 Apr 19, 2023

Choose a reason for hiding this comment

Uh oh!

z103cb Apr 19, 2023

Choose a reason for hiding this comment

Uh oh!

dmatch01 Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmatch01 left a comment

Choose a reason for hiding this comment

Uh oh!

dmatch01 Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asm582 commented Apr 30, 2023

Uh oh!

asm582 commented May 2, 2023

Uh oh!

jbusche commented May 3, 2023

Uh oh!

Uh oh!