Changes to the run-e2e-kind.sh locally #290

z103cb · 2023-03-23T11:07:21Z

This commit allows for the execution of the e2e on a local machine. Tests are failing when running locally, hence the WIP status of the PR.

test/e2e/queue.go

z103cb · 2023-03-27T10:45:41Z

@dmatch01 and @asm582 the build timeout after 60 minutes. Should I increase the timeout period ?

metalcycling

Could we get $IMAGE_ECHOSERVER (defined in line hack/run-e2e-kind.sh:35) from the environment variable as opposed to hardcoding it in the AppWrapper creating functions? Just wondering. I'm guessing the answer is no, but just to confirm.

hack/run-e2e-kind.sh

asm582 · 2023-03-28T21:02:07Z

@dmatch01 and @asm582 the build timeout after 60 minutes. Should I increase the timeout period ?

Do we know what is causing the build to go beyond 60 mins?

hack/e2e-kind-config.yaml

hack/run-e2e-kind.sh

test/e2e/util.go

z103cb · 2023-03-29T07:06:43Z

Could we get $IMAGE_ECHOSERVER (defined in line hack/run-e2e-kind.sh:35) from the environment variable as opposed to hardcoding it in the AppWrapper creating functions? Just wondering. I'm guessing the answer is no, but just to confirm.

I think it makes sense in the long term, but I think we should hold off on making this change. In the quota management branch we are using KUTTL for some of the e2e tests. We need to decide if we need to support both or standardise on one. For now I would prefer to to make the change we are discussing as part of the is PR.

@dmatch01 and @asm582 what are your thoughts ?

z103cb · 2023-03-29T07:08:43Z

@dmatch01 and @asm582 the build timeout after 60 minutes. Should I increase the timeout period ?

Do we know what is causing the build to go beyond 60 mins?
Nothing definitive, most of my local runs would finish a little more over 60 minute mark.

dmatch01

I did 3 of 6 but wanted to get those files at least.

Makefile

hack/e2e-kind-config.yaml

hack/run-e2e-kind.sh

metalcycling

Good on my end.

asm582

LGTM

dmatch01

Finished the other 3 files.

test/e2e/queue.go

* Build documentation updates.

dmatch01

Thanks so much for the updates. I have a few more comments from the new adds.

Makefile

doc/build/build.md

Fixed errors in the e2e script to load ubuntu:latest image correctly.

Rectified use of undefined variable.

Makefile

* update (#298) * Upgraded the golang version Updated travis config for the new version Updated build.sh scripts for the new version * Updates to go.mod Updates to travis.yml, to set dist Added the generated.deepcopy files * Removed unused package. * e2e test script updates * Queue.go updates Other fixes to the makefile and e2e test * Updates to the e2e script Updates to util.go to allow for different images to be used. * Updates to to local host setup * Changes to the run-e2e-kind.sh locally (#290) * Changes to the run-e2e-kind.sh to * Changed out echo server image, small edits * Backed out change in the clean up code. * Updated the makefile to build the executable * Address code review comments. * * Small changes to the e2e script * Build documentation updates. * Documentation updates per code review Fixed errors in the e2e script to load ubuntu:latest image correctly. * Cleaned up false errors Rectified use of undefined variable. * Downgraded go to version 1.18 to allow for use of ubi images. * Downgraded travis ubuntu distro * Added use of docker builder using ubi8 images Makefile updates * Cleaned up the obsolete build scripts Updated documentation Minor changes to makefile * avoid preempt of failed co-schd pods (#317) * Update CONTROLLER_VERSION * Updates to travis and devcontainer * Small updates to the run-e2e test * Updated go-restful dependency * More go.mod updates debug messages for the e2e script. * Added back in the removal of taints from head node Cleanup of junk files. * Remove whitesapce * Small corrections. * Refactoring of env-setup * moe arch issues with the kuttl binnary * Updated the go version in go.mod (#316) * Updated the go version in go.mod Ran `go mod tidy` Updated travis.yml Deleted staled code, disabled the quota manager in the controller. * Added travis changes. * Removed linter install Ported changes to .travis.yml from quota-management-branch * Removed linter install Ported changes to .travis.yml from quota-management-branch * Downgraded go to version 1.18 to allow for use of ubi images. * Added use of docker builder using ubi8 images Makefile updates * Cleaned up the obsolete build scripts Updated documentation Minor changes to makefile * Small fix to the docker file. * More updates to go.mod to fix vulnerabilities * Removed text files. * Yet another text file removal * Small fix to address PR review comments. * Create 1.29.57 release Signed-off-by: Anish Asthana <anishasthana1@gmail.com> * Adding Performance test script (#289) * Adding Performance test script Signed-off-by: James Busche <jbusche@us.ibm.com> * red hat image and more checking Signed-off-by: James Busche <jbusche@us.ibm.com> * Check for mcad install Signed-off-by: James Busche <jbusche@us.ibm.com> * remove oc and formatting Signed-off-by: James Busche <jbusche@us.ibm.com> * fix to run from any namespace Signed-off-by: James Busche <jbusche@us.ibm.com> --------- Signed-off-by: James Busche <jbusche@us.ibm.com> * fix typo (#326) * Document updates. * remove invalid characters from branch name an replace with - (#328) Signed-off-by: Kevin <kpostlet@redhat.com> * Bump golang.org/x/text from 0.3.4 to 0.3.8 (#321) Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.4 to 0.3.8. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.4...v0.3.8) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.0.0-20210405180319-a5a99cb37ef4 to 0.7.0 (#324) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20210405180319-a5a99cb37ef4 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](https://github.com/golang/net/commits/v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/gogo/protobuf from 1.3.1 to 1.3.2 (#323) Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/gogo/protobuf/releases) - [Commits](gogo/protobuf@v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: github.com/gogo/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added .devcontainer to gitignore Removed directory from commit. * Codereview comments. * Bump golang.org/x/crypto from 0.0.0-20201002170205-7f63de1d35b0 to 0.1.0 (#322) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20201002170205-7f63de1d35b0 to 0.1.0. - [Release notes](https://github.com/golang/crypto/releases) - [Commits](https://github.com/golang/crypto/commits/v0.1.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixes to the setup part of the script. * change schedSpec to schedulingSpec and note M1 image for echo server in tutorial (#333) Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> * Changes user to 1000 (#329) * non-root 1000 user Signed-off-by: James Busche <jbusche@us.ibm.com> * cleanup dockerfile Signed-off-by: James Busche <jbusche@us.ibm.com> * moving curl into builder Signed-off-by: James Busche <jbusche@us.ibm.com> --------- Signed-off-by: James Busche <jbusche@us.ibm.com> * Address race condition in XController variable (#330) * Update Dockerfile: * To not to use root user to build * To allow for passing of golang build args Updated Makefile: * To selectively run the generate code * To allow for passing of golang build args * Updates to ensure that docker builds flags are used Update to the e2e script to allow for not caching test runs and cluster setup * Updates to e2e script and travis for log level Fixed 1 race condition issue. * Reverted needless changes. * Documentation updates. Minor fixes to make file. * Fixed bug in docker file Reduced noise in e2e test. * Fixed potential regression. * Added back Dockerfile * Fix bad merge. --------- Signed-off-by: Anish Asthana <anishasthana1@gmail.com> Signed-off-by: James Busche <jbusche@us.ibm.com> Signed-off-by: Kevin <kpostlet@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Abhishek Malvankar <asm582@users.noreply.github.com> Co-authored-by: Mustafa Eyceoz <maxusmusti@gmail.com> Co-authored-by: Anish Asthana <anishasthana1@gmail.com> Co-authored-by: James Busche <101845348+jbusche@users.noreply.github.com> Co-authored-by: Lionel Villard <villard@us.ibm.com> Co-authored-by: Kevin Postlethwait <k.postlethwait24@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sunyanan Choochotkaew <sunya-ch@ist.osaka-u.ac.jp>

* Move POC rest impl. to quota plubins. * Initial checkin of new quota management. * Partial update to e2e script to enable instatiate 2 differently configured mcad controllers. * Added kuttl installation to e2e test. * Synced version file. * Modified kuttl installation to include sudo for commands. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added startup of MCAD with Quota Management enabled Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added kuttl test command to e2e testing. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Provided an alternative to the travis_wait command. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added full e2e testing back. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added explicit kuttl config file. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Set e2e test to above if kuttl test fails. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Uptick of release number. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Fix syntax error. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added creation of test namespace to kuttl testing steps. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test kuttl failure in Travis run. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test kuttle success run in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Fix job names to match file names and increased timeout for preemption to happen. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Increase kuttle timeout. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test kuttle success run in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Use different color code for e2e PID message. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Debugging kuttl failure. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Rearrange setup of kuttl test for more stability of test. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Introduced forced error test to validate new Travis workaround for long running Travis job. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Force final failure test for e2e kuttl test. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Removed forced failure for Travis testing. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added delay step 3 to give time for MCAD to process subtrees. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Updated QM test to use Helm3 Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Quota management porting of initial codebase (#269) * Move POC rest impl. to quota plubins. * Initial checkin of new quota management. * Partial update to e2e script to enable instatiate 2 differently configured mcad controllers. * Added kuttl installation to e2e test. * Synced version file. * Modified kuttl installation to include sudo for commands. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added startup of MCAD with Quota Management enabled Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added kuttl test command to e2e testing. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Provided an alternative to the travis_wait command. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added full e2e testing back. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added explicit kuttl config file. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Set e2e test to above if kuttl test fails. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Uptick of release number. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Fix syntax error. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added creation of test namespace to kuttl testing steps. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test kuttl failure in Travis run. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test kuttle success run in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Fix job names to match file names and increased timeout for preemption to happen. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Increase kuttle timeout. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test failure in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Test fix to make e2e test kuttle success run in background mode. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Use different color code for e2e PID message. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Debugging kuttl failure. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Rearrange setup of kuttl test for more stability of test. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Introduced forced error test to validate new Travis workaround for long running Travis job. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Force final failure test for e2e kuttl test. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Removed forced failure for Travis testing. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added delay step 3 to give time for MCAD to process subtrees. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Updated QM test to use Helm3 Signed-off-by: dmatch01 <darroyo@us.ibm.com> --------- Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Added the new path QM test using new Helm3 setup. Signed-off-by: dmatch01 <darroyo@us.ibm.com> * Upgrade the golang version for the quota-management branch. (#313) * update (#298) * Upgraded the golang version Updated travis config for the new version Updated build.sh scripts for the new version * Updates to go.mod Updates to travis.yml, to set dist Added the generated.deepcopy files * Removed unused package. * e2e test script updates * Queue.go updates Other fixes to the makefile and e2e test * Updates to the e2e script Updates to util.go to allow for different images to be used. * Updates to to local host setup * Changes to the run-e2e-kind.sh locally (#290) * Changes to the run-e2e-kind.sh to * Changed out echo server image, small edits * Backed out change in the clean up code. * Updated the makefile to build the executable * Address code review comments. * * Small changes to the e2e script * Build documentation updates. * Documentation updates per code review Fixed errors in the e2e script to load ubuntu:latest image correctly. * Cleaned up false errors Rectified use of undefined variable. * Downgraded go to version 1.18 to allow for use of ubi images. * Downgraded travis ubuntu distro * Added use of docker builder using ubi8 images Makefile updates * Cleaned up the obsolete build scripts Updated documentation Minor changes to makefile * avoid preempt of failed co-schd pods (#317) * Update CONTROLLER_VERSION * Updates to travis and devcontainer * Small updates to the run-e2e test * Updated go-restful dependency * More go.mod updates debug messages for the e2e script. * Added back in the removal of taints from head node Cleanup of junk files. * Remove whitesapce * Small corrections. * Refactoring of env-setup * moe arch issues with the kuttl binnary * Updated the go version in go.mod (#316) * Updated the go version in go.mod Ran `go mod tidy` Updated travis.yml Deleted staled code, disabled the quota manager in the controller. * Added travis changes. * Removed linter install Ported changes to .travis.yml from quota-management-branch * Removed linter install Ported changes to .travis.yml from quota-management-branch * Downgraded go to version 1.18 to allow for use of ubi images. * Added use of docker builder using ubi8 images Makefile updates * Cleaned up the obsolete build scripts Updated documentation Minor changes to makefile * Small fix to the docker file. * More updates to go.mod to fix vulnerabilities * Removed text files. * Yet another text file removal * Small fix to address PR review comments. * Create 1.29.57 release Signed-off-by: Anish Asthana <anishasthana1@gmail.com> * Adding Performance test script (#289) * Adding Performance test script Signed-off-by: James Busche <jbusche@us.ibm.com> * red hat image and more checking Signed-off-by: James Busche <jbusche@us.ibm.com> * Check for mcad install Signed-off-by: James Busche <jbusche@us.ibm.com> * remove oc and formatting Signed-off-by: James Busche <jbusche@us.ibm.com> * fix to run from any namespace Signed-off-by: James Busche <jbusche@us.ibm.com> --------- Signed-off-by: James Busche <jbusche@us.ibm.com> * fix typo (#326) * Document updates. * remove invalid characters from branch name an replace with - (#328) Signed-off-by: Kevin <kpostlet@redhat.com> * Bump golang.org/x/text from 0.3.4 to 0.3.8 (#321) Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.4 to 0.3.8. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.4...v0.3.8) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.0.0-20210405180319-a5a99cb37ef4 to 0.7.0 (#324) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20210405180319-a5a99cb37ef4 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](https://github.com/golang/net/commits/v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/gogo/protobuf from 1.3.1 to 1.3.2 (#323) Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/gogo/protobuf/releases) - [Commits](gogo/protobuf@v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: github.com/gogo/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added .devcontainer to gitignore Removed directory from commit. * Codereview comments. * Bump golang.org/x/crypto from 0.0.0-20201002170205-7f63de1d35b0 to 0.1.0 (#322) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20201002170205-7f63de1d35b0 to 0.1.0. - [Release notes](https://github.com/golang/crypto/releases) - [Commits](https://github.com/golang/crypto/commits/v0.1.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixes to the setup part of the script. * change schedSpec to schedulingSpec and note M1 image for echo server in tutorial (#333) Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> * Changes user to 1000 (#329) * non-root 1000 user Signed-off-by: James Busche <jbusche@us.ibm.com> * cleanup dockerfile Signed-off-by: James Busche <jbusche@us.ibm.com> * moving curl into builder Signed-off-by: James Busche <jbusche@us.ibm.com> --------- Signed-off-by: James Busche <jbusche@us.ibm.com> * Address race condition in XController variable (#330) * Update Dockerfile: * To not to use root user to build * To allow for passing of golang build args Updated Makefile: * To selectively run the generate code * To allow for passing of golang build args * Updates to ensure that docker builds flags are used Update to the e2e script to allow for not caching test runs and cluster setup * Updates to e2e script and travis for log level Fixed 1 race condition issue. * Reverted needless changes. * Documentation updates. Minor fixes to make file. * Fixed bug in docker file Reduced noise in e2e test. * Fixed potential regression. * Added back Dockerfile * Fix bad merge. --------- Signed-off-by: Anish Asthana <anishasthana1@gmail.com> Signed-off-by: James Busche <jbusche@us.ibm.com> Signed-off-by: Kevin <kpostlet@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Abhishek Malvankar <asm582@users.noreply.github.com> Co-authored-by: Mustafa Eyceoz <maxusmusti@gmail.com> Co-authored-by: Anish Asthana <anishasthana1@gmail.com> Co-authored-by: James Busche <101845348+jbusche@users.noreply.github.com> Co-authored-by: Lionel Villard <villard@us.ibm.com> Co-authored-by: Kevin Postlethwait <k.postlethwait24@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sunyanan Choochotkaew <sunya-ch@ist.osaka-u.ac.jp> --------- Signed-off-by: dmatch01 <darroyo@us.ibm.com> Signed-off-by: Anish Asthana <anishasthana1@gmail.com> Signed-off-by: James Busche <jbusche@us.ibm.com> Signed-off-by: Kevin <kpostlet@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com> Co-authored-by: dmatch01 <darroyo@us.ibm.com> Co-authored-by: dmatch01 <dmatch01@users.noreply.github.com> Co-authored-by: Laurentiu Bradin <109964136+z103cb@users.noreply.github.com> Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Mustafa Eyceoz <maxusmusti@gmail.com> Co-authored-by: Anish Asthana <anishasthana1@gmail.com> Co-authored-by: James Busche <101845348+jbusche@users.noreply.github.com> Co-authored-by: Lionel Villard <villard@us.ibm.com> Co-authored-by: Kevin Postlethwait <k.postlethwait24@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sunyanan Choochotkaew <sunya-ch@ist.osaka-u.ac.jp>

z103cb added 2 commits March 23, 2023 10:58

Changes to the run-e2e-kind.sh to

a407e48

Changed out echo server image, small edits

c7de3bd

z103cb marked this pull request as ready for review March 27, 2023 08:46

z103cb commented Mar 27, 2023

View reviewed changes

test/e2e/queue.go Show resolved Hide resolved

z103cb added 2 commits March 27, 2023 19:50

Backed out change in the clean up code.

ecfbb88

Updated the makefile to build the executable

3af04f3

metalcycling requested changes Mar 28, 2023

View reviewed changes

hack/run-e2e-kind.sh Outdated Show resolved Hide resolved

hack/run-e2e-kind.sh Outdated Show resolved Hide resolved

asm582 reviewed Mar 28, 2023

View reviewed changes

hack/e2e-kind-config.yaml Show resolved Hide resolved

hack/run-e2e-kind.sh Outdated Show resolved Hide resolved

test/e2e/util.go Outdated Show resolved Hide resolved

Address code review comments.

244c81c

z103cb requested review from metalcycling and asm582 and removed request for metalcycling and asm582 March 30, 2023 12:08

dmatch01 reviewed Mar 30, 2023

View reviewed changes

metalcycling previously approved these changes Mar 30, 2023

View reviewed changes

asm582 previously approved these changes Mar 30, 2023

View reviewed changes

dmatch01 self-requested a review March 31, 2023 23:23

dmatch01 reviewed Apr 1, 2023

View reviewed changes

test/e2e/queue.go Show resolved Hide resolved

* Small changes to the e2e script

da6e039

* Build documentation updates.

z103cb dismissed stale reviews from asm582 and metalcycling via da6e039 April 3, 2023 11:26

dmatch01 reviewed Apr 3, 2023

View reviewed changes

Makefile Show resolved Hide resolved

doc/build/build.md Outdated Show resolved Hide resolved

doc/build/build.md Outdated Show resolved Hide resolved

doc/build/build.md Show resolved Hide resolved

doc/build/build.md Outdated Show resolved Hide resolved

z103cb added 2 commits April 4, 2023 13:33

Documentation updates per code review

a9dec94

Fixed errors in the e2e script to load ubuntu:latest image correctly.

Cleaned up false errors

e76e53e

Rectified use of undefined variable.

dmatch01 approved these changes Apr 5, 2023

View reviewed changes

Makefile Show resolved Hide resolved

dmatch01 merged commit a83bcf7 into project-codeflare:main Apr 5, 2023

z103cb deleted the local_e2e_test branch April 13, 2023 07:43

Changes to the run-e2e-kind.sh locally #290

Changes to the run-e2e-kind.sh locally #290

Uh oh!

Conversation

z103cb commented Mar 23, 2023

Uh oh!

Uh oh!

z103cb commented Mar 27, 2023

Uh oh!

metalcycling left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

asm582 commented Mar 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

z103cb commented Mar 29, 2023

Uh oh!

z103cb commented Mar 29, 2023

Uh oh!

dmatch01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metalcycling left a comment

Choose a reason for hiding this comment

Uh oh!

asm582 left a comment

Choose a reason for hiding this comment

Uh oh!

dmatch01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dmatch01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!