Skip to content

test: update machinepool tests to identify machines based on label #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

test: update machinepool tests to identify machines based on label #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions test/e2e/instascale_machinepool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ limitations under the License.
package e2e

import (
"fmt"
"testing"

. "github.com/onsi/gomega"
Expand Down Expand Up @@ -49,14 +50,15 @@ func TestInstascaleMachinePool(t *testing.T) {
connection := CreateOCMConnection(test)
defer connection.Close()

// check existing cluster machine pool resources
// look for machine pool with aw name - expect not to find it
test.Expect(GetMachinePools(test, connection)).
ShouldNot(ContainElement(WithTransform(MachinePoolId, Equal("test-instascale-g4dn-xlarge"))))

// Setup batch job and AppWrapper
aw := instaScaleJobAppWrapper(test, namespace, cm)

expectedLabel := fmt.Sprintf("%s-%s", aw.Name, aw.Namespace)
// check existing cluster machine pool resources
// look for a machine pool with a label key equal to aw.name-aw.namespace - expect NOT to find it
test.Expect(GetMachinePools(test, connection)).
ShouldNot(ContainElement(WithTransform(MachinePoolLabels, HaveKey(expectedLabel))))

// apply AppWrapper to cluster
_, err := test.Client().MCAD().WorkloadV1beta1().AppWrappers(namespace.Name).Create(test.Ctx(), aw, metav1.CreateOptions{})
test.Expect(err).NotTo(HaveOccurred())
Expand All @@ -66,15 +68,15 @@ func TestInstascaleMachinePool(t *testing.T) {
test.Eventually(AppWrapper(test, namespace, aw.Name), TestTimeoutGpuProvisioning).
Should(WithTransform(AppWrapperState, Equal(mcadv1beta1.AppWrapperStateActive)))

// look for machine pool with aw name - expect to find it
// look for a machine pool with a label key equal to aw.name-aw.namespace - expect to find it
test.Eventually(MachinePools(test, connection), TestTimeoutLong).
Should(ContainElement(WithTransform(MachinePoolId, Equal("test-instascale-g4dn-xlarge"))))
Should(ContainElement(WithTransform(MachinePoolLabels, HaveKey(expectedLabel))))

test.Eventually(AppWrapper(test, namespace, aw.Name), TestTimeoutShort).
Should(WithTransform(AppWrapperState, Equal(mcadv1beta1.AppWrapperStateCompleted)))

// look for machine pool with aw name - expect not to find it
// look for a machine pool with a label key equal to aw.name-aw.namespace - expect NOT to find it
test.Eventually(MachinePools(test, connection), TestTimeoutLong).
ShouldNot(ContainElement(WithTransform(MachinePoolId, Equal("test-instascale-g4dn-xlarge"))))
ShouldNot(ContainElement(WithTransform(MachinePoolLabels, HaveKey(expectedLabel))))

}