test: update machinepool tests to identify machines based on label #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanillaSpoon
changed the title
VanillaSpoon
force-pushed
the
updateMachinePoolTests
branch
from
c4c9068 to
f1a56e0
Compare
VanillaSpoon
force-pushed
the
updateMachinePoolTests
branch
from
f1a56e0 to
7ec40bf
Compare
sutaakar
approved these changes
Feb 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
project-codeflare/instascale#143
What changes have been made
These changes are to align the instascale machinepool tests with project-codeflare/instascale#182. As opposed to checking for a specific machinepool ID the tests now check for the existence of a machinepool with a label key matching that of the appwrapper name.
This also relies on updating the codeflare-common repo with this pr
Checks