add: Print out parameters used in CodeFlare release workflow #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanillaSpoon
requested review from
sutaakar
and removed request for
anishasthana and
tedhtchang
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
closes #331
What changes have been made
This pr adds an additional job to the project codeflare release workflow, which will log the parameters set for the workflow.
The parameters will now be visible form
Actions,Project CodeFlare Release, and under the headingJobs.My reasoning to the separation of these logs into a Job, rather than in one of the logs of an already present job, is that this separation allows for the logs to be displayed even if any particular job is skipped.
ie) From Project CodeFlare Release 2, the parameters are visible in release-codeflare-operator due to the tag-and-build command:
However, in Project Codeflare Release 6 where the
release-codeflare-operatoris skipped, one would be unable to gather these values.Checks