-
Notifications
You must be signed in to change notification settings - Fork 61
[275] Implement ExposeService method #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[275] Implement ExposeService method #284
Conversation
57cef8b
to
8fe574b
Compare
@sutaakar |
3f46083
to
53adcbd
Compare
Please use the new function in https://github.com/project-codeflare/codeflare-operator/blob/a14914da37d61dd2e3de160c7033e3b2fe6d500e/test/e2e/mnist_rayjob_mcad_raycluster_test.go to make sure it works properly. |
905d05e
to
3f38926
Compare
Hello @sutaakar , I've tried to address all the comments. In the final version I removed KUBERNETES_HOSTNAME parameter at all. |
3f38926
to
8081d9b
Compare
Thank you @sutaakar for the review. I think I've addressed all your comments. |
test/support/route.go
Outdated
if r.Spec.Port.TargetPort.String() == "https" { | ||
scheme = "https" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I think about it again, this is not actually needed, as above we construct HTTP route anyway, so we are sure it is HTTP.
Can you please remove this code?
8081d9b
to
0565c27
Compare
/retest |
2 similar comments
/retest |
/retest |
0565c27
to
ee91bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Issue: #275
PR to distributed-workloads with changes to tests will follow.