Skip to content

[275] Implement ExposeService method #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jiripetrlik
Copy link
Contributor

Issue link

Issue: #275

PR to distributed-workloads with changes to tests will follow.

@jiripetrlik jiripetrlik force-pushed the 275-implement-expose-service branch from 57cef8b to 8fe574b Compare September 12, 2023 14:47
@jiripetrlik
Copy link
Contributor Author

@sutaakar
Thank you for the review. I've tried to address both your comments.

@jiripetrlik jiripetrlik force-pushed the 275-implement-expose-service branch 4 times, most recently from 3f46083 to 53adcbd Compare September 15, 2023 07:37
@sutaakar
Copy link
Contributor

Please use the new function in https://github.com/project-codeflare/codeflare-operator/blob/a14914da37d61dd2e3de160c7033e3b2fe6d500e/test/e2e/mnist_rayjob_mcad_raycluster_test.go to make sure it works properly.
Also the KUBERNETES_HOSTNAME needs to be set in PR check workflow.

@jiripetrlik jiripetrlik force-pushed the 275-implement-expose-service branch 3 times, most recently from 905d05e to 3f38926 Compare September 24, 2023 21:40
@jiripetrlik
Copy link
Contributor Author

Hello @sutaakar , I've tried to address all the comments. In the final version I removed KUBERNETES_HOSTNAME parameter at all.

@jiripetrlik jiripetrlik force-pushed the 275-implement-expose-service branch from 3f38926 to 8081d9b Compare September 25, 2023 22:10
@jiripetrlik
Copy link
Contributor Author

Thank you @sutaakar for the review. I think I've addressed all your comments.

Comment on lines 87 to 89
if r.Spec.Port.TargetPort.String() == "https" {
scheme = "https"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I think about it again, this is not actually needed, as above we construct HTTP route anyway, so we are sure it is HTTP.
Can you please remove this code?

@jiripetrlik jiripetrlik force-pushed the 275-implement-expose-service branch from 8081d9b to 0565c27 Compare September 26, 2023 09:02
@jiripetrlik
Copy link
Contributor Author

/retest

2 similar comments
@dimakis
Copy link
Contributor

dimakis commented Sep 26, 2023

/retest

@ChristianZaccaria
Copy link
Contributor

/retest

@jiripetrlik jiripetrlik force-pushed the 275-implement-expose-service branch from 0565c27 to ee91bff Compare September 26, 2023 13:41
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c3383c8 into project-codeflare:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants