fixes #906

[GaurangTandon]

I have verified that this pull request:

• has no linting errors (npm run lint)
• is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
• is descriptively named and links to an issue number, i.e. Fixes #123

fixes #906

I fixed the problem here by:

• simply checking if the confirm password field has at least one or more characters
• displaying the error message below the confirm password field instead of the password field. I think this is an additional improvement for intuitivity, as it is the second field that says "Confirm password", so it is the one that should say that passwords do not match. (GMail signup also works the same way)

Hope it is good. Please let me know of additional suggestions for improvement @catarak

[plxity]

Hey @GaurangTandon, Give suitable title to your PR. As it would make easier for everyone to know what is it about. :)

[GaurangTandon]

@plxity Hey, indeed I agree with you, but I have noticed that I do not get the sweet little reference box that I get otherwise right now. Notice the:

GaurangTandon referenced a pull request that will close this issue 18 hours ago

does appear on #931 but does not appear on #925, for which I made the PR #926, where I did pay attention to the title :(

I think those references are important but it's fine if titles are important too. Is there any other way to get those dynamic references?

[plxity]

@GaurangTandon oh okay, I got your point. Let's see if there is any other way for dynamic references. :).

[catarak]

@plxity / @GaurangTandon you can have both the ticket linking and a descriptive name! you would name the PR something like 'Fixes #906, "Passwords much match" error only appears if both password and confirm password are filled in'

[catarak]

this looks great though, merging!