Skip to content

change to acceptable contrast colors (fixes #925) #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

GaurangTandon
Copy link
Contributor

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak I have verified that the colors that I have now selected are well above the 4.5AA guideline. Is the new scheme fine?

One question though: secondary-text-color and inactive-text-color are now both the same. Would you want me to change them slightly? Secondary text color could be a bit bolder perhaps, or just simply an even darker shade of grey? Something like hsl(0, 0, 10%)?

@catarak
Copy link
Member

catarak commented Mar 20, 2019

can you change these colors based on the design on zeplin?

@catarak catarak closed this Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants