change to acceptable contrast colors (fixes #925) #926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this pull request:
npm run lint
)Fixes #123
@catarak I have verified that the colors that I have now selected are well above the 4.5AA guideline. Is the new scheme fine?
One question though:
secondary-text-color
andinactive-text-color
are now both the same. Would you want me to change them slightly? Secondary text color could be a bit bolder perhaps, or just simply an even darker shade of grey? Something likehsl(0, 0, 10%)
?