Skip to content

Delete unused code in CollectionView #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 17, 2023

Conversation

lindapaiste
Copy link
Collaborator

Fixes #2300

Should be reviewed/merged after #2295 because I using the useParams hook from react-router v5.1+

Changes:

  • Delete legacy code which doesn't do anything
  • Convert from a class component to a function component
  • No changes to behavior

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste mentioned this pull request Sep 19, 2023
3 tasks
@raclim raclim added this to the Next Release milestone Oct 18, 2023
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, I think this makes sense to me so far!

@raclim raclim merged commit 643443d into processing:develop Nov 17, 2023
@lindapaiste lindapaiste deleted the refactor/collection-view branch November 17, 2023 21:18
@raclim raclim moved this from PRs to Review to Done in PR Review Board May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Legacy code for an unreachable collection /create page
2 participants