Skip to content

Legacy code for an unreachable collection /create page #2300

Closed
@lindapaiste

Description

@lindapaiste

Increasing Access

Cleans up the codebase.

Feature enhancement details

In its current state, the CollectionView component doesn't do much of anything. There are two internal methods which are never called and a boolean check isCreatePage which will always be false.

The CollectionView is the route handler for the path "/:username/collections/:collection_id". It switches between displaying a single Collection and displaying the CollectionCreate UI based on whether the collection_id portion of the URL is the word "create" rather than a valid ID.

But the "/:username/collections/create" URL is impossible to reach, as the server only checks for a valid collection ID and will return a 404 page.

My plan is to delete the useless code. However we could make the "/:username/collections/create" URL work if we wanted to. Right now the UI for creating a collection is a modal that pops up over the "/:username/collections" page. There is no dedicated URL for this.

image

If the server code is changed, this is what would be displayed:
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: Code QualityFor refactoring, cleanup, or improvements to maintainability

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions