-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Feature/switch mobile desktop #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/switch mobile desktop #1564
Conversation
This is working great for me! Would it be possible to still render the desktop view if |
Great point, I'll make sure it works. I'm also working to make the desktop version renderable on mobile if the user prefers. |
TODO: fix TOGGLE_FORCE_DESKTOP not getting caught by reducer
…alestrilo/p5.js-web-editor into feature/switch-mobile-desktop
…/p5.js-web-editor into feature/switch-mobile-desktop
…/p5.js-web-editor into feature/switch-mobile-desktop
Done. You can now:
I was thinking: In the future, users may (?) want to
But I don't think these are priorities right now |
Working great for me ✨ |
Fixes #1524
This PR integrates mobile and desktop views under the same URLs, updating required redirects on mobile. A quick research indicates that
770px
is currently a good breakpoint for rendering mobile (which matches my previous experience with responsive layouts).I have verified that this pull request:
npm run lint
)Fixes #123