-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Login/Logout functionality to mobile layout #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Login/Logout functionality to mobile layout #1543
Conversation
I aligned the dropdown items! As discussed, I think it makes more sense to place the p5 logo on a new branch |
Ok! I think the p5 logo makes sense to go in another branch, and about the redirect: #1564 fixes it by making the mobile view render on the index endpoint, when appropriate. I'll work on the CSS to fix the header and merge this |
Updated the header on both
I'll merge this PR because others depend on it, but I we should test this on different resolutions before deploying, and open issues if changes are required. Edit: Needs a new review before merging ✨ @catarak please review it again when you can 😬 |
Just made a final update: right-aligning the language dropdown so it's visible on mobile |
Looks great to me 🌈 |
Requires #1528
This PR adds an option to the
<MobileIDEView />
Dropdown menu, allowing the user to log in and out successfully. The<Dropdown />
component has also been changed.npm run lint
)Fixes #123