Minimal Viable Navigation Menu #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translation with new namespace I18Next configuration leaning on default separator and namespace Broom: i18n + debug:false
|
Yay!!!! @andrewn I'll let you review this one? |
andrewn
suggested changes
Jul 22, 2020
|
Also, can you remove the commented out code in the About box. I checked with @catarak and she said it's ok. I think it's good not to have untranslated stuff as you convert everything! Thanks! |
Test entry for Toolbar.test.jsx
About : broom About lines 17-26 Nav component : changes in keys KeyboardShortcutModal.jsx: Key now in Common
Labels included in translations.json
Labels included in translations.json
Labels included in translations.json
Labels included in translations.json Snapshot updated npm run test -- -u
Updated names to call the labels Common namespace without currently used entries
|
Hi @andrewn , I'm updating the PR. |
Missing Common.p5logoARIA key
Deleting commented line 78
|
|
andrewn
reviewed
Jul 30, 2020
| @@ -10,31 +10,21 @@ function About(props) { | |||
| return ( | |||
| <div className="about__content"> | |||
| <Helmet> | |||
| <title>p5.js Web Editor | About </title> | |||
| <title>p5.js Web Editor | {t('About.TitleHelmet')} </title> | |||
There was a problem hiding this comment.
In the browser's title bar this shows:
p5.js Web Editor | p5.js Web Editor | About
|
I think this key needs to be updated...
|
|
@oruburos A couple of small things to fix then I think we're good to go! |
|
🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two aforementioned changes solve a double fetching that it is happening in the web editor.
But affects the keys that are present at the moment, so another change is present in this PR ( Related to #1492 `)
Components like Nav, Preferences, About, KeyboardShortcut and Toast (among others) are encapsulated in a prefix.
I have verified that this pull request:
npm run lint)