Skip to content

Add undocumented keyboard shortcut #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add undocumented keyboard shortcut #1332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d990c84
Add new keyboard shortcut entry
tirtawr Mar 18, 2020
d915dc2
Remove broken link from developer docs
tirtawr Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions client/modules/IDE/components/KeyboardShortcutModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ function KeyboardShortcutModal() {
</span>
<span>Find Previous Text Match</span>
</li>
<li className="keyboard-shortcut-item">
<span className="keyboard-shortcut__command">
{metaKeyName} + D
</span>
<span>Add Cursor at Next Text Match</span>
</li>
<li className="keyboard-shortcut-item">
<span className="keyboard-shortcut__command">
{metaKeyName} + [
Expand Down
1 change: 0 additions & 1 deletion developer_docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
This folder contains documents intended for developers of the p5.js Web Editor.

## List of Documents
* [Getting Started](getting_started.md) - A place to get started!
Copy link
Contributor

@shakti97 shakti97 Mar 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make your pr feature wise, you are commiting two different changes in same pr and I think you should not remove the getting started from docs instead of that you should find the correct link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha. While we're on this, the getting_started.md file doesn't really exist and the purpose of it is already served by this README.md file.

* [Installation](installation.md) - A guide for setting up your development environment
* [Development](development.md) - A guide for adding code to the web editor
* [Preparing a pull-request](preparing_a_pull_request.md) - Instructions for how to make a pull-request
Expand Down