Skip to content

Add undocumented keyboard shortcut #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tirtawr
Copy link
Contributor

@tirtawr tirtawr commented Mar 18, 2020

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Mar 18, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@@ -1,7 +1,6 @@
This folder contains documents intended for developers of the p5.js Web Editor.

## List of Documents
* [Getting Started](getting_started.md) - A place to get started!
Copy link
Contributor

@shakti97 shakti97 Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make your pr feature wise, you are commiting two different changes in same pr and I think you should not remove the getting started from docs instead of that you should find the correct link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha. While we're on this, the getting_started.md file doesn't really exist and the purpose of it is already served by this README.md file.

@tirtawr
Copy link
Contributor Author

tirtawr commented Mar 18, 2020

Closing, split into #1333 and #1335

@tirtawr tirtawr closed this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants