Skip to content

Squash CI Bugs #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Squash CI Bugs #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25b64d4
adding names to ci steps
Jan 5, 2020
788a206
restoring http call to chopper.ply
Jan 6, 2020
b713545
Revert "restoring http call to chopper.ply"
Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
version: 2
jobs:
build:
ignore:
branches:
ignore:
- built
working_directory: ~/project
docker:
Expand All @@ -15,6 +16,7 @@ jobs:
keys:
- cache2
- run:
name: Install container-level dependencies
command: |
sudo apt-get update -y
sudo apt-get install -y curl python3-pip python3-venv ssh-client ssh git
Expand All @@ -23,6 +25,7 @@ jobs:
name: Keyscan Github (HACK)
command: ssh-keyscan -H github.com >> ~/.ssh/known_hosts
- run:
name: install application-level dependencies
command: |
sudo apt-get install -y pandoc libudunits2-dev libgdal-dev libxt-dev libglu1-mesa-dev
sudo R -e 'install.packages(c("curl", "devtools", "mvtnorm")); devtools::install_github("hypertidy/anglr"); devtools::install_github("johannesbjork/LaCroixColoR"); devtools::install_deps(dependencies = TRUE) '
Expand All @@ -34,6 +37,7 @@ jobs:
path: man/
destination: man
- run:
name: build site and perform front-matter checks
command: |
rm -rf build
mkdir build
Expand All @@ -49,14 +53,15 @@ jobs:
curl https://raw.githubusercontent.com/plotly/documentation/source-design-merge/check-or-enforce-order.py > check-or-enforce-order.py
python check-or-enforce-order.py build/r
- run:
name: deploy to plotly/r.docs:built
command: |
if [ "${CIRCLE_BRANCH}" == "master" ]; then
cd build
git init
git config user.name plotlydocbot
git config user.email accounts@plot.ly
rm -rf r/*.html
sed -i.bkp 's/<!--.*-->//g' r/*md && rm r/*.bkp
sed -i.bkp 's/<!--.*-->//g' r/*md && rm r/*.bkp # remove html comments
rm -rf ggplot2/*.html
sed -i.bkp 's/<!--.*-->//g' ggplot2/*md && rm ggplot2/*.bkp
git add *
Expand All @@ -66,7 +71,7 @@ jobs:
fi

- run:
name: trigger doc build
name: trigger plotly/documentation build
command: |
if [ "${CIRCLE_BRANCH}" == "master" ]; then
git clone --depth=1 --branch=source-design-merge https://github.com/plotly/documentation.git
Expand Down
1 change: 1 addition & 0 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Imports:
readr,
MASS,
htmltools,
random,
tidyr,
broom,
cli,
Expand Down
7 changes: 1 addition & 6 deletions r/2016-06-17-3d-tri-surf.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,7 @@ p
library(plotly)
library(geomorph)

plyFile <- 'http://people.sc.fsu.edu/~jburkardt/data/ply/chopper.ply'
dest <- basename(plyFile)
if (!file.exists(dest)) {
download.file(plyFile, dest)
}

dest <- "data/chopper.ply"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this must be inlined and no other files? Just the download.file command doesn’t work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m fine with inlining, just curious about when we must vs can just continue as was

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to access the file at the URL, the following error is thrown:

trying URL 'http://people.sc.fsu.edu/~jburkardt/data/ply/chopper.ply'
Quitting from lines 73-106 (2016-06-17-3d-tri-surf.Rmd) 
Error in download.file(plyFile, dest) : 
  cannot open URL 'http://people.sc.fsu.edu/~jburkardt/data/ply/chopper.ply'
Calls: <Anonymous> ... withCallingHandlers -> withVisible -> eval -> eval -> download.file
In addition: Warning messages:
1: In rgl.init(initValue, onlyNULL) : RGL: unable to open X11 display
2: 'rgl_init' failed, running with rgl.useNULL = TRUE 
3: In download.file(plyFile, dest) :
  URL 'https://people.sc.fsu.edu/~jburkardt/data/ply/chopper.ply': status was 'SSL connect error'

I believe SSL is set up correctly in the container, as libcurl4-openssl-dev and ca-certificates are both installed. Seems like an issue with the server?

mesh <- read.ply(dest)
# see getS3method("shade3d", "mesh3d") for details on how to plot

Expand Down
4 changes: 2 additions & 2 deletions r/2017-01-19-buttons.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,8 @@ library(plotly)
# Sys.setenv('MAPBOX_TOKEN' = 'your mapbox token')

# read in wind turbines and farms data
df_wind = read.csv('https://plot.ly/~datasets/2805.csv')
df_farms = read.csv('https://plot.ly/~jackp/17256.csv')
df_wind = read.csv('data/2805.csv')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why must we in-line this one and not the next one? Seems odd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of the command df_wind = read.csv('https://plot.ly/~datasets/2805.csv') is:

df_wind = read.csv('https://plot.ly/~datasets/2805.csv')

 *** caught segfault ***
address 0x10b966000, cause 'memory not mapped'

Traceback:
 1: scan(file = file, what = what, sep = sep, quote = quote, dec = dec,     nmax = nrows, skip = 0, na.strings = na.strings, quiet = TRUE,     fill = fill, strip.white = strip.white, blank.lines.skip = blank.lines.skip,     multi.line = FALSE, comment.char = comment.char, allowEscapes = allowEscapes,     flush = flush, encoding = encoding, skipNul = skipNul)
 2: read.table(file = file, header = header, sep = sep, quote = quote,     dec = dec, fill = fill, comment.char = comment.char, ...)
 3: read.csv("https://plot.ly/~datasets/2805.csv")

Inlining solves the error, which does not appear for df_farms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird

df_farms = read.csv('https://plot.ly/~jackp/17256.csv', skipNul = TRUE)

# subset and clean data
df_sub <- subset(df_wind, manufac != "unknown", select=c(lat_DD, long_DD, manufac))
Expand Down
Loading