Skip to content

Bump tinycolor2 to 1.4.1 - as well as few dev-dependencies #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Bump tinycolor2 to 1.4.1 - as well as few dev-dependencies #3948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"strongly-connected-components": "^1.0.1",
"superscript-text": "^1.0.0",
"svg-path-sdf": "^1.1.3",
"tinycolor2": "^1.3.0",
"tinycolor2": "^1.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Why isn't there any diff in the package-lock.json file for tinycolor2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was resolved in lock right from the beginning!

git blame -L 11245,+2 -- package-lock.json
671861a2da (etienne 2018-02-01 16:31:41 -0500 11245)     "tinycolor2": {
671861a2da (etienne 2018-02-01 16:31:41 -0500 11246)       "version": "1.4.1",

671861a#diff-32607347f8126e6534ebc7ebaec4853d

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. tinycolor2 was already listed as 1.4.1 in our package-lock, but we never propagate the change to the package.json.

Thanks very much for cleaning that up!

"topojson-client": "^2.1.0",
"webgl-context": "^2.2.0",
"world-calendars": "^1.0.3"
Expand All @@ -126,12 +126,12 @@
"derequire": "^2.0.6",
"ecstatic": "^3.3.1",
"eslint": "^5.16.0",
"falafel": "^2.0.0",
"falafel": "^2.1.0",
"fs-extra": "^2.0.0",
"fuse.js": "^3.4.4",
"fuse.js": "^3.4.5",
"glob": "^7.1.4",
"gzip-size": "^5.1.0",
"image-size": "^0.6.3",
"gzip-size": "^5.1.1",
"image-size": "^0.7.4",
"into-stream": "^4.0.0",
"jasmine-core": "^2.99.1",
"jsdom": "^11.12.0",
Expand Down Expand Up @@ -160,6 +160,6 @@
"through2": "^3.0.1",
"true-case-path": "^1.0.3",
"watchify": "^3.11.1",
"xml2js": "^0.4.16"
"xml2js": "^0.4.19"
}
}