Bump tinycolor2 to 1.4.1 - as well as few dev-dependencies #3948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Jun 11, 2019
| @@ -111,7 +111,7 @@ | |||
| "strongly-connected-components": "^1.0.1", | |||
| "superscript-text": "^1.0.0", | |||
| "svg-path-sdf": "^1.1.3", | |||
| "tinycolor2": "^1.3.0", | |||
| "tinycolor2": "^1.4.1", | |||
There was a problem hiding this comment.
Weird. Why isn't there any diff in the package-lock.json file for tinycolor2?
There was a problem hiding this comment.
It was resolved in lock right from the beginning!
git blame -L 11245,+2 -- package-lock.json
671861a2da (etienne 2018-02-01 16:31:41 -0500 11245) "tinycolor2": {
671861a2da (etienne 2018-02-01 16:31:41 -0500 11246) "version": "1.4.1",
There was a problem hiding this comment.
Got it. tinycolor2 was already listed as 1.4.1 in our package-lock, but we never propagate the change to the package.json.
Thanks very much for cleaning that up!
|
💃 - don't worry about the failing License test, those shouldn't run on feature branches (for now 😏 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@plotly/plotly_js