Skip to content

Replace Hero BG Image #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 15, 2019
Merged

Replace Hero BG Image #1455

merged 3 commits into from
Aug 15, 2019

Conversation

jdamiba
Copy link
Contributor

@jdamiba jdamiba commented Aug 13, 2019 •
edited
Loading

closes #1425
Screen Shot 2019-08-13 at 11 57 02 AM

@jdamiba jdamiba requested a review from michaelbabyn August 13, 2019 16:01
@jdamiba
Copy link
Contributor Author

jdamiba commented Aug 13, 2019

@michaelbabyn When reviewing this PR, please take note of how the background extends extends the full width of the hero- this was an issue @nicolaskruchten highlighted in the previous PR.

See #1428 (comment)

@nicolaskruchten
Copy link
Contributor

Please note the font in the mock for #1425 ... it's Asap rather than Open Sans :)

@jdamiba
Copy link
Contributor Author

jdamiba commented Aug 13, 2019

@nicolaskruchten I am confused by your comment, can you please be more specific? Please see the following gif of this PR in my development environment.

The pretitle and subtitle are Open Sans while the <h2> title is Asap, as in the mock. To confirm that the title is Asap I toggle the font-family style in the Inspector several times which reverts the title to Open Sans and back to Asap quickly.

screencast

@nicolaskruchten
Copy link
Contributor

Something is likely not loaded (the font itself?) because the font in the image above is not actually Asap. The lowercase Ls in "Plotly" in particular, compared to the mock in #1425 and compared to the font reference at https://fonts.google.com/specimen/Asap.

@jdamiba
Copy link
Contributor Author

jdamiba commented Aug 14, 2019

Thanks for clarifying @nicolaskruchten. I added a commit to include the Asap Google Font in the <head> on the website.

Screen Shot 2019-08-14 at 10 40 35 AM

@michaelbabyn This PR should be good to go now.

michaelbabyn
michaelbabyn approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@michaelbabyn michaelbabyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @jdamiba 💃

@jdamiba jdamiba merged commit 26cf65f into source-design-merge Aug 15, 2019
@jdamiba jdamiba deleted the hero-bg-image branch August 15, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbabyn michaelbabyn michaelbabyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace hero image/fonts on https://plot.ly/graphing-libraries/
3 participants
@jdamiba @nicolaskruchten @michaelbabyn