Edits to Documentation Landing Page #1428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamiba
changed the title
|
Ideally the hero would extend all the way to the edge of the page on both sides, and there would be just a 1px gap between the nav and the hero. On the marketing side I believe this is implemented via a 1px lower border on the navbar actually. |
|
Got it- I will take a look at how that behaviour is implemented in |
|
I'm closing this PR in favor of #1436 which addresses the changes that are ready to be merged with production (removing breadcrumbs and additional resources section). A separate draft PR will be opened to resolve the issue of the updated hero image not extending the full width. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1425