Skip to content

Alias std::isfinite to isfinite #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion Vagrantfile
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,30 @@ Vagrant.configure("2") do |config|
end


#
# ubuntu xenial(16.04) box with PHP 7.1.3, V8 5.2
# (to reproduce issue #304)
#
config.vm.define "xenial-v8-5.2" do |i|
i.vm.box = "ubuntu/xenial64"
i.vm.synced_folder ".", "/data/v8js"

i.vm.provision "shell", inline: <<-SHELL
gpg --keyserver keys.gnupg.net --recv 7F438280EF8D349F
gpg --armor --export 7F438280EF8D349F | apt-key add -

apt-get update
apt-get install -y software-properties-common gdb tmux git tig curl apache2-utils lcov

add-apt-repository ppa:ondrej/php
add-apt-repository ppa:pinepain/libv8-5.2
apt-get update
apt-get install -y php7.1-dev libv8-5.2-dbg libv8-5.2-dev
SHELL
end


config.vm.provision "shell", inline: <<-SHELL
mkdir -p /data/build && chown vagrant:vagrant /data/build
mkdir -p /data/build && chown 1000:1000 /data/build
SHELL
end
3 changes: 3 additions & 0 deletions php_v8js_macros.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
/* php.h requires the isnan() macro, which is removed by c++ <cmath> header,
* work around: re-define the macro to std::isnan function */
#define isnan(a) std::isnan(a)

/* likewise isfinite */
#define isfinite(a) std::isfinite(a)
#endif

extern "C" {
Expand Down