Skip to content

Alias std::isfinite to isfinite #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2017
Merged

Alias std::isfinite to isfinite #305

merged 2 commits into from
Mar 16, 2017

Conversation

stesie
Copy link
Member

@stesie stesie commented Mar 16, 2017

PHP 7.1.3 seems to have started using isfinite via zend_isfinite in our callpath now :-)

cmath c++ header however undefines isfinite macro

@stesie stesie merged commit bbe06c4 into phpv8:php7 Mar 16, 2017
@stesie stesie deleted the issue-304 branch April 14, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant