Fixed parser so that square brackets count as delimiters

[dantleech]

This is an "enabling" improvement which allows me to use the parser to parse things like:

UPDATE [foo] SET foo = ['foo','bar',baz'];

Square brackets are delimiters in JCR-SQL2 (right?) so I think this is valid without compromise.

[dantleech]

This should simply be $this->scanner->expectToken(']');

[dbu]

+1

[dbu]

yeah, [] are used for indexes and are not legal in a node name. however, i am not entirely sure if this change could lead to some regression somewhere in jackalope, when we assume that /foo[3]/bar[2] would work. then again, jackalope officially does not support same name siblings yet.

is using square brakets for index in multivalue lists something ever used by jcr sql2? i think not, as you don't care about position in a multivalue.

[lsmith77]

tests seem to be flaky on HHVM .. some of the tests sometimes fail with a 1 second timeout

[lsmith77]

as you might be aware Oak does not support SNS and there is a discussion about how to deal with people importing content with SNS, so they are discussing how to deal with square brackets in node names. maybe this discussions will give some hints:
http://www.mail-archive.com/oak-dev@jackrabbit.apache.org/msg06825.html

[dantleech]

So just to clarify - does this change (using square brackets in an UPDATE in PHPCR-Shell) conflict with SNS?

I guess it shouldn't, i.e. SNS square brackets are only used on paths, whereas the UPDATE square brackets are only used on properties.

I guess in any case it shouldn't be hard to support SNS notation with this change.

[lsmith77]

the concern is just that this change MIGHT break parsing of SNS paths inside queries.

ie. for example WHERE ISDESCENDANTNODE('/foo[2]')

[dbu]

As we only ever update properties and never whole nodes i think Dan is right.

----- Reply message -----
Von: "dantleech" notifications@github.com
An: "phpcr/phpcr-utils" phpcr-utils@noreply.github.com
Cc: "David Buchmann" david@liip.ch
Betreff: [phpcr-utils] Fixed parser so that square brackets count as delimiters (#121)
Datum: Mi., Sep. 3, 2014 04:50
So just to clarify - does this change (using square brackets in an UPDATE in PHPCR-Shell) conflict with SNS?

I guess it shouldn't, i.e. SNS square brackets are only used on paths, whereas the UPDATE square brackets are only used on properties.

I guess in any case it shouldn't be hard to support SNS notation with this change.

—
Reply to this email directly or view it on GitHub.

[dantleech]

Are we OK to merge this?

[dbu]

lets merge. ok @lsmith77 ?

[dbu]

i think this breaks jackalope: https://travis-ci.org/jackalope/jackalope-jackrabbit/jobs/37503114

[dantleech]

ok, I wasn't aware that there were tests for these classes in the API tests.

The other problems are "ok" - they make sense and I guess just need to be updated, but this one is odd:

PHPCR\Query\InvalidQueryException: Syntax error: Expected ')', found '/home' in SELECT * FROM [nt:file] AS file INNER JOIN [nt:folder] AS folder ON ISSAMENODE(file, folder, [/home])

Caused by this:

        $queries['6.7.9.SameNodeJoinCondition.Path_Space'] = array(
            'SELECT * FROM [nt:file] AS file INNER JOIN [nt:folder] AS folder ON ISSAMENODE(file, folder, ["/home node"])',
            'SELECT * FROM [nt:file] AS file INNER JOIN [nt:folder] AS folder ON ISSAMENODE(file, folder, [/home node])',
        );

Why are there square brackets there? Is the spec suggesting that the square brackets are part of the grammer, or simply that it is an optional thing?

But we can revert first and ask questions later if needs be :)

[dbu]

as long as we don't tag a release lets see if we can clear this up without reverting. created #131