failing tests after change for square brackets

[dbu]

follow-up of #121

@dantleech said:

PHPCR\Query\InvalidQueryException: Syntax error: Expected ')', found '/home' in SELECT * FROM [nt:file] AS file INNER JOIN [nt:folder] AS folder ON ISSAMENODE(file, folder, [/home])

Caused by this:

        $queries['6.7.9.SameNodeJoinCondition.Path_Space'] = array(
            'SELECT * FROM [nt:file] AS file INNER JOIN [nt:folder] AS folder ON ISSAMENODE(file, folder, ["/home node"])',
            'SELECT * FROM [nt:file] AS file INNER JOIN [nt:folder] AS folder ON ISSAMENODE(file, folder, [/home node])',
        );

Why are there square brackets there? Is the spec suggesting that the square brackets are part of the grammer, or simply that it is an optional thing?

[dbu]

tried to find the definition of that but found nothing in jcr spec, but then found this here: http://docs.jboss.org/jbossdna/0.7/manuals/reference/html/jcr-query-and-search.html#d0e7952

it indicates that what we do in the test indeed would be correct.

[dbu]

@dantleech do you agree? and do you think you can fix the parser to again support this scenario?

[dantleech]

Yeah by that definition I guess. Any idea what the logic is behind that?

I think updating the parser is may be tricky - the impression I got is that its not that clever, but I was going to have a closer look anyway as I don't think quotes are handled very well.

[dantleech]

Hmm. It is tricky. I wonder if it wouldn't be better to leave it as it was, and instead I could implement a function in phpcr-shell:

UPDATE foo SET a = array('asd', 'foo', 'bar')

instead of

UPDATE foo SET a = ['asd', 'foo', 'bar']

This would also reuse more code which is a plus.

[dantleech]

Oops, don't know why I closed this issue.