fix previous refactoring of parseLiteral() to parseListeralValue() #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return LiteralInterface | ||
| */ | ||
| protected function parseFulltextLiteral() |
There was a problem hiding this comment.
this method seems to be unused
| @@ -772,7 +772,7 @@ protected function parseCastLiteral($token) | |||
| throw new InvalidQueryException("Syntax error: attempting to cast string '$token' to type '$type'"); | |||
| } | |||
|
|
|||
| return $this->factory->literal($token); | |||
| return $token; | |||
There was a problem hiding this comment.
ah. did you grep if we have other places that could have similar issues?
There was a problem hiding this comment.
the issue is limited to places where we return in parseLiteralValue() and all of these cases are now covered.
|
looks right to me. surprised about the unused method though. |
|
the unused method seems to have been added accidentally in 57dbaef |
lsmith77
added a commit
that referenced
this pull request
Jul 25, 2014
fix previous refactoring of parseLiteral() to parseListeralValue()
|
thanks lukas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for regression introduced in #118