Refactored Converter to make it more extensible #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -782,7 +782,7 @@ protected function parseCastLiteral($token) | |||
| * | |||
| * @return LiteralInterface | |||
| */ | |||
| protected function parseLiteral() | |||
| protected function parseLiteralValue() | |||
There was a problem hiding this comment.
This method now simply returns the literal value not the LiteralValueIntreface object - which is only used directly once anyway.
|
cool! the only worry is the sql2 field that is now commented out. |
- Minor refactorings to make the class more reutilizable
|
Updated, Apparently the comment thing is "valid" according to PHP, fixed in anycase. Added a test to ensure that the class is at least instantiable. |
|
Failing on benchmark test: |
dbu
added a commit
that referenced
this pull request
Jul 18, 2014
…endable Refactored Converter to make it more extensible
|
benchmark seems a close one, travis did not fail on the last update of your commit :-) |
|
this merge is causing a regression: |
This was referenced Jul 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made in association with: phpcr/phpcr-shell#68