-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Adapt ext/intl tests for ICU 72.1 #9800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This version replaces SPACEs before the meridian with NARROW NO-BREAK SPACEs. Thus, we split the affected test cases as usual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of adding numbers to the file name having something like _icu72-1
at the end is better so that at a glance one can see why there are different variants?
That makes sense, but how should we suffix files which are for ICU x - ICU y? There are quite a lot of these. Or apply that naming scheme only to new files? |
Hum, maybe if there is a version number X than the test is for that version and above. However if there is another copy of the test with a higher version number Y than the test for version above X becomes between version X and Y? |
Thank you! that fixes build, at least all upgraded arches are pass now https://gitlab.alpinelinux.org/alpine/aports/-/pipelines/140943 |
Regarding the test names, see PR php#9800.
Regarding the test names, see PR php#9800. Closes phpGH-16660. (cherry picked from commit 3245a65)
This version replaces SPACEs before the meridian with NARROW NO-BREAK SPACEs. Thus, we split the affected test cases as usual.
Fixes GH-9799.