Adapt ext/intl tests for ICU 76.1 #16788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e111bf7)
Apparently, the error message may contain the called function.
|
I also backported the test fixes for ICU 75.1, and had to adapt a new test case. |
|
Shouldn't this target 8.1 instead? |
|
I think we need to lock 8.1 to ICU 74 anyway, since otherwise we would need to introduce support for C++17 into the security branch (see #16789). I doubt that we should do that (user can update to PHP 8.2 or later, if they want to use latest ICU versions). And if we don't support ICU >= 75 for PHP-8.1, there is no need to update the tests. |
ericmann
pushed a commit
that referenced
this pull request
Nov 19, 2024
adoy
pushed a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the test names, see PR #9800.
(cherry picked from commit 3245a65)
macOS CI is now using ICU 76.1 so we need to backport the test fix. I should probably have targeted PHP-8.2 in the first place.