Fix GH-9653: does not inconditionally support copy_file_range on olde… #9656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
copy_file_range_disable_for_old_kernels
branch
from
f005046 to
418e0fc
Compare
devnexen
force-pushed
the
copy_file_range_disable_for_old_kernels
branch
from
c3392d4 to
fc97cf5
Compare
bukka
approved these changes
Oct 6, 2022
configure.ac
Outdated
| @@ -691,6 +690,33 @@ if test "$ac_cv_func_getaddrinfo" = yes; then | |||
| AC_DEFINE(HAVE_GETADDRINFO,1,[Define if you have the getaddrinfo function]) | |||
| fi | |||
|
|
|||
| AC_CACHE_CHECK([for copy_file_range], ac_cv_copy_file_range, | |||
| [AC_RUN_IFELSE([AC_LANG_SOURCE([[ | |||
| #if defined(__linux__) | |||
There was a problem hiding this comment.
Suggested change
| #if defined(__linux__) | |
| #ifdef __linux__ |
devnexen
force-pushed
the
copy_file_range_disable_for_old_kernels
branch
from
fc97cf5 to
4d30a3c
Compare
…lder kernels. As mentioned in its manpage, it had been reworked in the 5.3 line to support cross filesystem interactions.
devnexen
force-pushed
the
copy_file_range_disable_for_old_kernels
branch
from
4d30a3c to
fa57cd8
Compare
|
@bukka how does it look to you now ? |
|
Looks good |
devnexen
added a commit
that referenced
this pull request
Oct 11, 2022
…r kernels. As mentioned in its manpage, it had been reworked in the 5.3 line to support cross filesystem interactions. Closes #GH-9656
|
Merged as c15fe519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r kernels.
As mentioned in its manpage, it had been reworked in the 5.3 line to support cross filesystem interactions.