Skip to content

Explode _php_image_output_ctx() into multiple functions #5844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Explode _php_image_output_ctx() into multiple functions #5844

wants to merge 3 commits into from

Conversation

kocsismate
Copy link
Member

As requested in #5598

@kocsismate kocsismate requested a review from cmb69 July 11, 2020 19:59
@kocsismate kocsismate force-pushed the explode_php_image_output_ctx branch from d09e326 to 6786fc8 Compare July 11, 2020 20:28
cmb69
cmb69 reviewed Jul 11, 2020
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'll have a closer look tomorrow, but a few comments right away:

nikic
nikic reviewed Jul 13, 2020
View reviewed changes
@kocsismate
Copy link
Member Author

@cmb69 just a subtle ping :)

@cmb69
Copy link
Member

cmb69 commented Jul 20, 2020

Sorry for the delay! The PR looks good to me now; a follow-up could be getting rid of the UNKNOWN defaults (and the arg count checks).

@kocsismate
Copy link
Member Author

@cmb69 Thank you for the review! The follow-up is already in place (#5598), I just need a rebase as soon as this PR is merged :)

cmb69
cmb69 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I complete forgot about the other PR. Please go ahead and merge this one. Thanks.

@php-pulls php-pulls closed this in 19bf66a Jul 20, 2020
@kocsismate kocsismate deleted the explode_php_image_output_ctx branch July 20, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @cmb69 @nikic