Skip to content

Fix UNKNOWN default values in ext/xml-rpc, ext/mbstring, and ext/gd #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix UNKNOWN default values in ext/xml-rpc, ext/mbstring, and ext/gd #5598

wants to merge 2 commits into from

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate force-pushed the nullable-default4 branch 2 times, most recently from 1888012 to f35ac99 Compare May 19, 2020 09:04
kocsismate
kocsismate commented May 19, 2020
View reviewed changes
carusogabriel
carusogabriel reviewed May 19, 2020
View reviewed changes
@kocsismate kocsismate force-pushed the nullable-default4 branch 2 times, most recently from dacbf09 to 003aba6 Compare May 25, 2020 15:41
@nikic
Copy link
Member

nikic commented May 25, 2020

Segfaults in CI are from d609882.

@kocsismate kocsismate force-pushed the nullable-default4 branch from 166f047 to 75ff463 Compare May 26, 2020 05:34
nikic
nikic reviewed May 26, 2020
View reviewed changes
nikic
nikic reviewed May 26, 2020
View reviewed changes
nikic
nikic reviewed May 26, 2020
View reviewed changes
nikic
nikic reviewed May 26, 2020
View reviewed changes
nikic
nikic reviewed May 26, 2020
View reviewed changes
nikic
nikic reviewed May 26, 2020
View reviewed changes
nikic
nikic reviewed May 26, 2020
View reviewed changes
@kocsismate kocsismate force-pushed the nullable-default4 branch 3 times, most recently from 6aa50f6 to a99f20b Compare May 28, 2020 07:58
kocsismate
kocsismate commented May 28, 2020
View reviewed changes
@kocsismate kocsismate force-pushed the nullable-default4 branch from a99f20b to 2984edc Compare May 28, 2020 09:33
nikic
nikic reviewed May 28, 2020
View reviewed changes
@kocsismate kocsismate force-pushed the nullable-default4 branch 2 times, most recently from 0bb4b15 to 789077b Compare May 28, 2020 09:46
@nikic
Copy link
Member

nikic commented May 28, 2020

The xmlrpc changes LGTM now, feel free to already commit those to get that unblocked.

@kocsismate kocsismate force-pushed the nullable-default4 branch from 789077b to aa44a8e Compare May 28, 2020 10:50
@kocsismate
Copy link
Member Author

@cmb69 xmlrpc is good to go now :)

nikic
nikic reviewed Jun 16, 2020
View reviewed changes
@kocsismate kocsismate mentioned this pull request Jul 11, 2020
Closed
@kocsismate kocsismate force-pushed the nullable-default4 branch 2 times, most recently from 8f44ac6 to 1cba4eb Compare July 21, 2020 17:17
@kocsismate
Copy link
Member Author

@cmb69 Could you please take another look at the recent changes about the image* functions?

I think the PR is fairly close to be ready for the merge, since it has been reviewed a few times before. :)

cmb69
cmb69 reviewed Jul 27, 2020
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmb69 Could you please take another look at the recent changes about the image* functions?

Thanks! Looks pretty good to me, but maybe have an eye on the two minor issues mentioned below.

@php-pulls php-pulls closed this in ac0da09 Jul 28, 2020
@kocsismate kocsismate deleted the nullable-default4 branch July 28, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@carusogabriel carusogabriel carusogabriel left review comments

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kocsismate @nikic @cmb69 @carusogabriel