mysqlnd: Remove unnecessary check for HAVE_ZLIB #5658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ee4295b, the
zlibpackage is explicitly checked for and configuration will fail without it. However,HAVE_ZLIB, which isn't defined by the configuration script, still has to be defined inmysqlnd.hfor compression support to be turned on. This removes this requirement, which seems like a leftover. It probably only succeeds when buildingmysqlndas a part of PHP becauseHAVE_ZLIBgets defined by thezlibextension.In the NixOS project, we build the extensions separately, for maximal flexibility, and so we ran into this problem: NixOS/nixpkgs#89266
Related PR: #5655