Define HAVE_ZLIB for myslnd #5655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building just the mysqlnd extension, HAVE_ZLIB might not be set, leading to a missing compression support.
10 tasks
nikic
reviewed
Jun 3, 2020
| PKG_CHECK_MODULES([ZLIB], [zlib]) | ||
| PKG_CHECK_MODULES([ZLIB], [zlib], [ | ||
| AC_DEFINE(HAVE_ZLIB, 1, "ZLIB support") | ||
| ]) | ||
| PHP_EVAL_LIBLINE($ZLIB_LIBS, MYSQLND_SHARED_LIBADD) | ||
| PHP_EVAL_INCLINE($ZLIB_CFLAGS) | ||
| AC_DEFINE([MYSQLND_COMPRESSION_WANTED], 1, [Enable compressed protocol support]) |
There was a problem hiding this comment.
This looks unnecessarily complicated. I'd instead replace MYSQLND_COMPRESSION_WANTED here with MYSQLND_COMPRESSION_ENABLED and then drop the block at
Lines 49 to 51 in d237989
There's no reason why we need both MYSQLND_COMPRESSION_WANTED and HAVE_ZLIB here. (Keep in mind that PKG_CHECK_MODULES is going to hard error if zlib is not found.)
|
Superseded by: #5658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building just the mysqlnd extension, HAVE_ZLIB might not be set, leading to a missing compression support.