Improve gen_stub.php #5350
Closed
Improve gen_stub.php #5350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Apr 4, 2020
kocsismate
force-pushed
the
stub-generator-improvement
branch
from
a0e6ace to
23a3581
Compare
Add support for generating deprecated function entries, as well as forward declaration of function aliases.
kocsismate
force-pushed
the
stub-generator-improvement
branch
2 times, most recently
from
001ea78 to
42dd726
Compare
kocsismate
force-pushed
the
stub-generator-improvement
branch
from
42dd726 to
50a90f1
Compare
nikic
approved these changes
Apr 4, 2020
| @@ -737,6 +743,7 @@ function generateCodeWithConditions( | |||
| } | |||
|
|
|||
| function generateArgInfoCode(FileInfo $fileInfo): string { | |||
| $generatedDeclarations = []; | |||
There was a problem hiding this comment.
This variable can be moved closer to where it is used.
There was a problem hiding this comment.
Forgot to do this - but I'll fix it soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generating deprecated function entries, as well as forward declaration of function aliases.