Address code review comments

Author: kocsismate

build/gen_stub.php

@@ -422,7 +422,7 @@ function parseDocComment(DocComment $comment): array {
     $commentText = substr($comment->getText(), 2, -2);
     $tags = [];
     foreach (explode("\n", $commentText) as $commentLine) {
-        $regex = '/^\*\s*@([a-z-]+)(?:\s+(.+))$/';
+        $regex = '/^\*\s*@([a-z-]+)(?:\s+(.+))?$/';
         if (preg_match($regex, trim($commentLine), $matches, PREG_UNMATCHED_AS_NULL)) {
             $tags[] = new DocCommentTag($matches[1], $matches[2]);
         }
@@ -743,6 +743,7 @@ function generateCodeWithConditions(
 }
 
 function generateArgInfoCode(FileInfo $fileInfo): string {
+    $generatedDeclarations = [];
     $funcInfos = $fileInfo->funcInfos;
 
     $code = "/* This is a generated file, edit the .stub.php file instead. */\n";
@@ -767,22 +768,14 @@ function(FuncInfo $funcInfo) use(&$generatedFuncInfos) {
 
     if ($fileInfo->generateFunctionEntries) {
         $code .= "\n\n";
-        $code .= generateCodeWithConditions($funcInfos, "", function(FuncInfo $funcInfo) use ($funcInfos) {
-            $result = "";
-
-            if ($funcInfo->alias) {
-                foreach ($funcInfos as $info) {
-                    if ($info->name === $funcInfo->alias) {
-                        return null;
-                    }
-                }
-
-                $result .= "ZEND_FUNCTION($funcInfo->alias);\n";
+        $code .= generateCodeWithConditions($funcInfos, "", function(FuncInfo $funcInfo) use (&$generatedDeclarations) {
+            $name = $funcInfo->alias ?? $funcInfo->name;
+            if (isset($generatedDeclarations[$name])) {
+                return null;
             }
 
-            $result .= "ZEND_FUNCTION($funcInfo->name);\n";
-
-            return $result;
+            $generatedDeclarations[$name] = true;
+            return "ZEND_FUNCTION($name);\n";
         });
 
         $code .= "\n\nstatic const zend_function_entry ext_functions[] = {\n";

ext/bz2/bz2_arginfo.h

@@ -49,11 +49,8 @@ ZEND_END_ARG_INFO()
 ZEND_FUNCTION(bzopen);
 ZEND_FUNCTION(bzread);
 ZEND_FUNCTION(fwrite);
-ZEND_FUNCTION(bzwrite);
 ZEND_FUNCTION(fflush);
-ZEND_FUNCTION(bzflush);
 ZEND_FUNCTION(fclose);
-ZEND_FUNCTION(bzclose);
 ZEND_FUNCTION(bzerrno);
 ZEND_FUNCTION(bzerrstr);
 ZEND_FUNCTION(bzerror);

ext/ldap/ldap_arginfo.h

@@ -353,9 +353,6 @@ ZEND_END_ARG_INFO()
 #if defined(HAVE_ORALDAP)
 ZEND_FUNCTION(ldap_connect);
 #endif
-#if !(defined(HAVE_ORALDAP))
-ZEND_FUNCTION(ldap_connect);
-#endif
 ZEND_FUNCTION(ldap_unbind);
 ZEND_FUNCTION(ldap_bind);
 ZEND_FUNCTION(ldap_bind_ext);

ext/zend_test/test.stub.php

@@ -18,7 +18,7 @@ function zend_test_nullable_array_return(): ?array {}
 
 function zend_test_void_return(): void {}
 
-/** @deprecated since 5.0 */
+/** @deprecated */
 function zend_test_deprecated(): void {}
 
 function zend_create_unterminated_string(string $str): string {}