Skip to content

Remove custom 'v' spprintf format and 'I' length modifier #5108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove custom 'v' spprintf format and 'I' length modifier #5108

wants to merge 2 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jan 23, 2020

Mimicking from the changes made to snprintf

Grep search: https://gist.github.com/Girgias/f03ae14ffa5f2f8bc8ae81ef66b06743

@Girgias Girgias mentioned this pull request Jan 23, 2020
Closed
nikic
nikic approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpdbg failures are unrelated, so this lgtm.

@php-pulls php-pulls closed this in 2b5fb76 Jan 23, 2020
@Girgias Girgias deleted the remove-custom-spprintf-format branch January 23, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nikic