Remove custom 'p' length modifier from custom snprintf implementation

[Girgias]

From my understanding this gives a zend_long representation, however it seems to be unused going from this grep search: https://gist.github.com/Girgias/06253c18fde29af25ed50b29c0d8da38

Possibly because the long format macros also take care of this modifier? Or maybe it's just mostly used in conjunction with spprintf (which I'll need to make a separate search for).

(Drive by the mysqlnd usage seems to suggest to output a pointer which we don't really support fully from my understanding).

[nikic]

I think it's pretty likely that this one is used by extensions. We originally used %pd to print zend_long, but later switched to ZEND_LONG_FMT because it plays better with compiler checks for printf.

Can you check usages in PECL extensions for this?

[Girgias]

On Tue, 21 Jan 2020, 13:18 Nikita Popov, ***@***.***> wrote: I think it's pretty likely that this one is used by extensions. We originally used %pd to print zend_long, but later switched to ZEND_LONG_FMT because it plays better with compiler checks for printf. Can you check usages in PECL extensions for this?

I thought so, is there a tool to easily check PECL extensions? Or does it need to be done manually?

…

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5103?email_source=notifications&email_token=AB4KLAFV2RZODZOH33I52OTQ63Y27A5CNFSM4KJSV4S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJPWKTA#issuecomment-576677196>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4KLAB6OLGLFO34P4CZUPDQ63Y27ANCNFSM4KJSV4SQ> .

[nikic]

I think @petk used to do this, maybe he can share how it's done?

[Girgias]

Made a second commit which removes it from the custom spprintf implementation too, updated the gist accordingly with the grep secondary grep search.

[nikic]

Speaking of, can you please also apply the I / v removals you did to spprintf? If they're gone from snprintf, they should be gone there as well.

[Girgias]

@nikic See #5108, seems I need to do some fixes to phpdbg

[petk]

To search occurrences in extensions back then, I've used very dummy technique:

• a script with a bit of a configuration that downloads all php extensions set in the configuration and then I think grep -Eri 'keyword' was used over those folders. I think I've made a list of those extensions from some pecl XML files and some here https://github.com/gophp7/gophp7-ext/wiki/extensions-catalog. I'll see if I can share that list in some repo or something...

[Girgias]

@petk did you have time to look into it?

[Girgias]

Small ping @petk did you have time to look into this?

[petk]

Hello, nope. Don't wait for me here with this check. No time for this script atm :)

[Girgias]

Hello, nope. Don't wait for me here with this check. No time for this script atm :)

Mind providing the script so that I can run it myself or too complicated?

[Girgias]

This has been done in 0d6358f