Skip to content

Drop 'v' format from custom snprintf #5100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Drop 'v' format from custom snprintf #5100

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jan 20, 2020

Basing myself on: https://gist.github.com/Girgias/b9a2b9926190630d433c84da0ef1b002

For extensions relying on this format the v must be changed to the standard s format.

@Girgias
Copy link
Member Author

Girgias commented Jan 21, 2020

Azure Pipeline test failures are unrelated.

@php-pulls php-pulls closed this in 1317808 Jan 21, 2020
@Girgias Girgias deleted the drop-v-format-custom-snprintf branch January 21, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nikic