Skip to content

Commit 1317808

Browse files
committed
Drop the custom 'v' format from snprintf custom implementation.
Extensions should instead use the standard 's' format. Closes GH-5100
1 parent 5a6f3de commit 1317808

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

UPGRADING.INTERNALS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,9 @@ PHP 8.0 INTERNALS UPGRADE NOTES
8686
Use the ZEND_LONG_FMT, ZEND_ULONG_FMT and ZEND_XLONG_FMT macros defined in
8787
php-src/Zend/zend_long.h
8888

89+
The 'v' format from the custom snprintf implementation has been removed.
90+
Use the standard 's' format instead.
91+
8992
========================
9093
2. Build system changes
9194
========================

main/snprintf.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,6 @@ static int format_converter(register buffy * odp, const char *fmt, va_list ap) /
961961

962962

963963
case 's':
964-
case 'v':
965964
s = va_arg(ap, char *);
966965
if (s != NULL) {
967966
s_len = strlen(s);

0 commit comments

Comments
 (0)