Skip to content

Throw exception for unconstructed intl objects #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kocsismate
Copy link
Member

Discussed in #4819 (comment)

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG assuming CI happy.

@kocsismate
Copy link
Member Author

kocsismate commented Jan 4, 2020

It is not :( + I missed out the stub changes for IntlTimeZone. Will change them later

@fanqingxuan
Copy link

hi friends,I saw you contribute code to php-src project.
for example the file of php-src/ext/json/json.stub.php
I am also a php programer. I am from China.
I want to know how to generate the stub file as json.stub.php for the php extension.
I saw the stub.php file in every extension.
I think it should not maintence by manual. I should generate by command .
Do you know the generate method?
Thanks

@cmb69
Copy link
Member

cmb69 commented Jan 4, 2020

@fanqingxuan, actually, the foo_arginfo.h files are generated from foo.stub.php by doing php scripts/dev/gen_stub.php foo.stub.php. Usually, this happens automatically.

@fanqingxuan
Copy link

hi , another question. we can use --proto to generate function with ext-skel script . but php7 delete the usage with ext-skel.php . how to generate function with proto . or do you have quick method to generate skel for functions or classes . write code in .c file by manual?

@kocsismate kocsismate force-pushed the intl-unconstructed-exception branch from 22b858e to 5d2fba0 Compare January 5, 2020 17:06
@php-pulls php-pulls closed this in 019e8d4 Jan 5, 2020
@kocsismate kocsismate deleted the intl-unconstructed-exception branch January 5, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants